Hi Manujith, Good to see the project reaching final stages. Please find the comments inline.
Thanks, Pushpalanka On Thu, Aug 11, 2016 at 1:23 PM, Manujith Pallewatte <manujith...@gmail.com> wrote: > UPDATE > > Adding missing links > [1] http://docs.oasis-open.org/xacml/xacml-rest/v1.0/csprd03 > /xacml-rest-v1.0-csprd03.html > [2] http://docs.oasis-open.org/xacml/xacml-json-http/v1.0/ > xacml-json-http-v1.0.html > [3] http://manzzup.github.io/wso2-entitlement-endpoint/devdoc > > On Thu, Aug 11, 2016 at 1:22 PM, Manujith Pallewatte < > manujith...@gmail.com> wrote: > >> Hi all, >> >> To update on the current status >> 1) The endpoint is fully compliant with the XACML REST profile as stated >> here [1] >> 2) It is also in accordance with the JSON XACML request/response profile >> as stated in [2], except few things that require changes to balana >> > Can you please list down these things and the changes required in Balana, so that we can address them at least later. > 3) Developer documentation was generated after fully commenting the >> important codes and available for now at [3] >> > Additionally would be good to have the design details at github it self as well or linked to your blog at http://manzzup.blogspot.com/2016/08/gsoc-2016-rest-implementation-for-wso2.html . > >> Hoping to work on user documentation and integration tests and submit a >> new PR within next week >> Any ideas for improvements / ideas / changes to be done prior to the PR? >> >> Thank You >> Manujith >> >> >> >> On Wed, Jul 13, 2016 at 2:49 PM, Manujith Pallewatte < >> manujith...@gmail.com> wrote: >> >>> Hi all, >>> >>> With the previous suggestions i'm currently working on having Swagger >>> integrated to the service. According to the Apache CXF documentation [1] >>> Swagger can be implemented easily by using its Swagger2Feature library. But >>> their documentation provides no integration details. >>> >>> So i integrated the library using some other docs [2], which now shows >>> no errors in integration, but when I try to access the api-docs usrl (ex: >>> https://localhost:9443/wso2-entitlement/api-docs) it simply shows >>> >>> *"No service was found." * in the browser and gives [3] in the console >>> as a warning. >>> Please let me know if there's any solutions or any idea why this might >>> be occurring. >>> >>> Thank You >>> Manujith >>> >>> [1] https://cwiki.apache.org/confluence/pages/viewpage.actio >>> n?pageId=61318164 >>> [2] http://stackoverflow.com/questions/36035393/how-to-integ >>> rate-swagger-tool-with-apache-cxf-rest-web-service-using-cxfnonsprin >>> [3] >>> [http-nio-9443-exec-31] WARN >>> org.apache.cxf.transport.servlet.ServletController >>> - Can't find the the request forhttps://localhost:9443/wso2 >>> -entitlement/entitlement/api-docs's >>> <https://www.google.com/url?q=https%3A%2F%2Flocalhost%3A9443%2Fwso2-entitlement%2Fentitlement%2Fapi-docs%27s&sa=D&sntz=1&usg=AFQjCNF1VqSODX6CxpcxwdMMPvQb_6OE9Q> >>> Observer >>> >>> On Wed, Jul 6, 2016 at 6:24 PM, Manujith Pallewatte < >>> manujith...@gmail.com> wrote: >>> >>>> Hi Pushpalanka, >>>> >>>> Thank you for the comments, I'm currently looking into Swagger >>>> Since it's already used in WSO2 API Manager, can i know if it's built >>>> on CXF as well? In that case I can use existing swagger libraries than >>>> introducing new ones. I found Swagger2Feature [1] library as in the Apache >>>> CXF documentation. >>>> >>>> Hi Prabath, >>>> Sorry i'm not familiar with those mentioned, can you clarify a bit >>>> more, I would like to help in making any improvements >>>> >>>> Thank You >>>> Manujith >>>> >>>> [1] http://cxf.apache.org/docs/swagger2feature.html >>>> >>>> On Tue, Jul 5, 2016 at 8:42 PM, Prabath Siriwardana <prab...@wso2.com> >>>> wrote: >>>> >>>>> When we are implementing the REST profile XACML - can we implement it >>>>> as a microservice on MSF4J? It needs to be an independent deployable unit >>>>> - >>>>> which should function with a set of policies loaded from the filesystem... >>>>> Can we do this..? >>>>> >>>>> Thanks & regards, >>>>> -Prbath >>>>> >>>>> On Mon, Jul 4, 2016 at 11:44 PM, Pushpalanka Jayawardhana < >>>>> la...@wso2.com> wrote: >>>>> >>>>>> Hi Manujith, >>>>>> >>>>>> Please find the comments in line. >>>>>> >>>>>> On Mon, Jul 4, 2016 at 8:11 PM, Manujith Pallewatte < >>>>>> manujith...@gmail.com> wrote: >>>>>> >>>>>>> Hi all, >>>>>>> >>>>>>> So to start working on the points discussed in the mid evaluation, >>>>>>> first is to align the service with the REST profile of XACML 3.0 [1] >>>>>>> But according to the spec only the following 2 resources are defined >>>>>>> >>>>>>> 1) home - entry point for REST service, returns links to other >>>>>>> resources >>>>>>> 2) pdp - resource that given a XACML request presents the XACML >>>>>>> response >>>>>>> >>>>>>> but since the existing SOAP entitlement service exposes additional >>>>>>> services such as >>>>>>> getBooleanDecision, getDecisionByAttributes etc. there arises 2 >>>>>>> issues >>>>>>> >>>>>>> 1) how to name those additional resources? >>>>>>> >>>>>> Let's have some convincing names for you as of now. We can refine >>>>>> them later in review. Try to have inputs from the topic "5.1 PROPER >>>>>> NAMING" >>>>>> from the rest api guideline while paper we pointed before. >>>>>> >>>>>>> 2) how to let the clients accessing the service know of the required >>>>>>> structure of each of these requests that are not defined in the XACML >>>>>>> spec? >>>>>>> >>>>>> Please have a look at the possibility of using swagger for this. This >>>>>> is already used in WSO2 Api Manager[1], but not yet in WSO2 IS. Would be >>>>>> great if you can evaluate the possibility of using it. Basic idea is to >>>>>> represent the REST API according to Swagger specification similar to WSDL >>>>>> we have for SOAP. >>>>>> >>>>>> [1] - https://docs.wso2.com/display/AM1100/Edit+an+API+Using+the >>>>>> +Swagger+UI >>>>>> >>>>>>> >>>>>>> Please provide your suggestions on this >>>>>>> >>>>>>> Thank You >>>>>>> Best Regards, >>>>>>> Manujith >>>>>>> >>>>>>> [1] http://docs.oasis-open.org/xacml/xacml-rest/v1.0/csprd03 >>>>>>> /xacml-rest-v1.0-csprd03.html >>>>>>> >>>>>>> On Thu, Jun 23, 2016 at 3:42 PM, Omindu Rathnaweera <omi...@wso2.com >>>>>>> > wrote: >>>>>>> >>>>>>>> Good Work Manujith! >>>>>>>> >>>>>>>> Adding to this. Figure out a way to drop null values from the JSON >>>>>>>> response with Jackson level configurations. Also have a look at XACML >>>>>>>> JSON >>>>>>>> profile [1]. It will have guidelines on dealing with JSON >>>>>>>> inputs/outputs. >>>>>>>> >>>>>>>> [1] - http://docs.oasis-open.org/xacml/xacml-json-http/v1.0/xacm >>>>>>>> l-json-http-v1.0.html >>>>>>>> >>>>>>>> Regards, >>>>>>>> Omindu. >>>>>>>> >>>>>>>> On Thu, Jun 23, 2016 at 3:31 PM, Manujith Pallewatte < >>>>>>>> manujith...@gmail.com> wrote: >>>>>>>> >>>>>>>>> Hi all, >>>>>>>>> >>>>>>>>> We had the mid-evaluation review, and I've summarized the key >>>>>>>>> points discussed here >>>>>>>>> >>>>>>>>> 1) Prioritize on the complete JSON implementation for all 5 >>>>>>>>> services methods >>>>>>>>> 2) Comply the service fully with XACML 3.0 REST specification >>>>>>>>> (Read on the spec and get a firm understanding on all key concepts) >>>>>>>>> 3) Leave the hard coded authenticators as it is for now >>>>>>>>> 4) Using custom client / server exception to be returned in a case >>>>>>>>> of an exception >>>>>>>>> 5) Follow the code quality guidelines (specially in the cases of >>>>>>>>> improper exception handling) >>>>>>>>> >>>>>>>>> Special thanks to everyone for their time in reviewing. >>>>>>>>> >>>>>>>>> Thank You, >>>>>>>>> Manujith >>>>>>>>> >>>>>>>>> On Sun, Jun 12, 2016 at 10:43 PM, Manujith Pallewatte < >>>>>>>>> manujith...@gmail.com> wrote: >>>>>>>>> >>>>>>>>>> Hi all, >>>>>>>>>> >>>>>>>>>> After refactoring and reviewing code using above suggestions, I >>>>>>>>>> added a PR, which can be found at [1] >>>>>>>>>> >>>>>>>>>> Regards, >>>>>>>>>> Manujith >>>>>>>>>> >>>>>>>>>> [1] https://github.com/wso2/carbon-identity-framework/pull/282 >>>>>>>>>> >>>>>>>>>> On Sat, Jun 11, 2016 at 12:52 PM, Manujith Pallewatte < >>>>>>>>>> manujith...@gmail.com> wrote: >>>>>>>>>> >>>>>>>>>>> Hi Manuranga, >>>>>>>>>>> >>>>>>>>>>> I did referred to the guidelines, but was not successful in >>>>>>>>>>> figuring out suitable end point names. So Pushpalanka suggested to >>>>>>>>>>> take >>>>>>>>>>> community's ideas in naming them. Any pointers as for which I can >>>>>>>>>>> improve >>>>>>>>>>> the names? According to the guide it says to identify the resources >>>>>>>>>>> first >>>>>>>>>>> Going on that, I identified the Policy Decision, Entitlement >>>>>>>>>>> Attributes and Entitlements as resources, but since some resources >>>>>>>>>>> have >>>>>>>>>>> only one methods call in it, having a separate path seem redundant. >>>>>>>>>>> And >>>>>>>>>>> didnt follow much from there, please let me know your ideas on the >>>>>>>>>>> resource >>>>>>>>>>> identification >>>>>>>>>>> >>>>>>>>>>> Thank You >>>>>>>>>>> Regards, >>>>>>>>>>> Manujith >>>>>>>>>>> >>>>>>>>>>> On Sat, Jun 11, 2016 at 12:21 AM, Manuranga Perera < >>>>>>>>>>> m...@wso2.com> wrote: >>>>>>>>>>> >>>>>>>>>>>> Hi Manujith, >>>>>>>>>>>> >>>>>>>>>>>> Please have a look at WSO2 REST API guideline [1]. This will >>>>>>>>>>>> help you to improve the URL nameing. >>>>>>>>>>>> >>>>>>>>>>>> [1] http://wso2.com/whitepapers/ws >>>>>>>>>>>> o2-rest-apis-design-guidelines/ >>>>>>>>>>>> >>>>>>>>>>>> On Thu, Jun 9, 2016 at 3:49 PM, Manujith Pallewatte < >>>>>>>>>>>> manujith...@gmail.com> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> Hi Pushpalanka, >>>>>>>>>>>>> >>>>>>>>>>>>> Was confused in the PR procedure, and figured that I forgot to >>>>>>>>>>>>> initialize the github repo as you have mentioned in a previous >>>>>>>>>>>>> message. >>>>>>>>>>>>> So the new location of the codebase is at [1] >>>>>>>>>>>>> Over the weekend, I'll fix any remaining issues and send the PR >>>>>>>>>>>>> For now I have used the wso2-codestyle given by Omindu and >>>>>>>>>>>>> reformatted the code >>>>>>>>>>>>> and added Findbug as well. >>>>>>>>>>>>> >>>>>>>>>>>>> Thank You >>>>>>>>>>>>> Manujith >>>>>>>>>>>>> >>>>>>>>>>>>> [1] https://github.com/ManZzup/identity-framework/tree/maste >>>>>>>>>>>>> r/components/entitlement/org.wso2.carbon.identity.entitlemen >>>>>>>>>>>>> t.endpoint >>>>>>>>>>>>> >>>>>>>>>>>>> On Wed, Jun 8, 2016 at 11:35 AM, Pushpalanka Jayawardhana < >>>>>>>>>>>>> la...@wso2.com> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> On Tue, Jun 7, 2016 at 11:01 AM, Manujith Pallewatte < >>>>>>>>>>>>>> manujith...@gmail.com> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>>> Hi all, >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Code is almost all refracted (apart from the part where >>>>>>>>>>>>>>> authenticators are hard coded) and it' is available at [1] >>>>>>>>>>>>>>> I have attached a readme so everyone can help with testing >>>>>>>>>>>>>>> it. But there's still an issue remaining to debug with the >>>>>>>>>>>>>>> *entitled-attribs >>>>>>>>>>>>>>> *service call, that came up in preliminary testing by >>>>>>>>>>>>>>> Omindu. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Thank You Omindu, I will use the formatting configs and >>>>>>>>>>>>>>> format the code asap. For now i added a gitignore as in the >>>>>>>>>>>>>>> sample you >>>>>>>>>>>>>>> sent, but I left *target *directory intact so that i can >>>>>>>>>>>>>>> share the war file through the repo. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Also for the PR, to which repo should I send the PR for? Or >>>>>>>>>>>>>>> shall I wait for further testing of the code so that we can >>>>>>>>>>>>>>> minimize any >>>>>>>>>>>>>>> bugs? >>>>>>>>>>>>>>> >>>>>>>>>>>>>> If code refactoring, formatting, cleanup are done, you have >>>>>>>>>>>>>> run Findbug plugin(This is a plugin that can integrate to IDE. >>>>>>>>>>>>>> If you >>>>>>>>>>>>>> already haven't try it.) and fixed any issues reported against >>>>>>>>>>>>>> code and >>>>>>>>>>>>>> functionality is working, we are OK to review the code. You can >>>>>>>>>>>>>> further >>>>>>>>>>>>>> test the code and fix the bugs while integrating any review >>>>>>>>>>>>>> comments we put >>>>>>>>>>>>>> on the PR. >>>>>>>>>>>>>> >>>>>>>>>>>>>> "Please share the code progress via Github, once you are >>>>>>>>>>>>>> satisfied with refactoring. >>>>>>>>>>>>>> Please fork [1] to your private repo, and at location [2], >>>>>>>>>>>>>> you may have a new component named >>>>>>>>>>>>>> 'org.wso2.carbon.identity.entitlement.endpoint' >>>>>>>>>>>>>> where the implementation can reside. >>>>>>>>>>>>>> >>>>>>>>>>>>>> [1] - https://github.com/wso2/carbon-identity-framework >>>>>>>>>>>>>> [2] - https://github.com/wso2/carb >>>>>>>>>>>>>> on-identity-framework/tree/master/components/entitlement" >>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> [1] https://github.com/ManZzup/identity-entitlement-endpoint >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Thank You, >>>>>>>>>>>>>>> Best Regards >>>>>>>>>>>>>>> Manujith >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> On Tue, Jun 7, 2016 at 10:30 AM, Omindu Rathnaweera < >>>>>>>>>>>>>>> omi...@wso2.com> wrote: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Adding a .gitignore to the repo will be the easiest way to >>>>>>>>>>>>>>>> keep the unwanted files away from the repo. See [1]. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> [1] - https://github.com/wso2/carb >>>>>>>>>>>>>>>> on-identity-framework/blob/master/.gitignore >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Regards, >>>>>>>>>>>>>>>> Omindu >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> On Tue, Jun 7, 2016 at 10:26 AM, Pushpalanka Jayawardhana < >>>>>>>>>>>>>>>> la...@wso2.com> wrote: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Hi Manujith, >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> The IDE specific files(.iml) or code can be removed from >>>>>>>>>>>>>>>>> the repository. >>>>>>>>>>>>>>>>> Once the code refactoring is done and code is cleaned >>>>>>>>>>>>>>>>> please feel free to send the PR. Then we can easily comment >>>>>>>>>>>>>>>>> on the code. >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>>>> Pushpalanka >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> On Tue, Jun 7, 2016 at 10:12 AM, Omindu Rathnaweera < >>>>>>>>>>>>>>>>> omi...@wso2.com> wrote: >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Hi Manujith, >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Better if you can clean up the unnecessary code and do >>>>>>>>>>>>>>>>>> some code refactoring. We can do another round of testing >>>>>>>>>>>>>>>>>> once you fix the >>>>>>>>>>>>>>>>>> issues I have mention. You can use the attached Idea Code >>>>>>>>>>>>>>>>>> Formatting >>>>>>>>>>>>>>>>>> Template [1]. >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> To apply the template, follow the steps below. >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> 1. In IDEA settings, goto Editor -> Code Style. >>>>>>>>>>>>>>>>>> 2. Click 'Manage' then 'Save As...' an existing scheme >>>>>>>>>>>>>>>>>> with the name 'wso2-codestyle' and Close the IDE. >>>>>>>>>>>>>>>>>> 3. Goto ~/.IntelliJIdea16/config/codestyles directory >>>>>>>>>>>>>>>>>> and replace the 'wso2-codestyle.xml' file with the attached >>>>>>>>>>>>>>>>>> one. >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> [1] - https://drive.google.com/fil >>>>>>>>>>>>>>>>>> e/d/0BzRDbfbIaYjCSzhGRUR1aGdlTXM/view?usp=sharing >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Regards, >>>>>>>>>>>>>>>>>> Omindu. >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> On Mon, Jun 6, 2016 at 8:29 AM, Manujith Pallewatte < >>>>>>>>>>>>>>>>>> manujith...@gmail.com> wrote: >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> Hi all, >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> After a bit of refactoring I added the code to [1]. >>>>>>>>>>>>>>>>>>> Please feel free to check the source and give your ideas to >>>>>>>>>>>>>>>>>>> improve, >>>>>>>>>>>>>>>>>>> specially on the service related code. All the service >>>>>>>>>>>>>>>>>>> related code is >>>>>>>>>>>>>>>>>>> available at [2] >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> Also Omindu tested the initial war file and reported >>>>>>>>>>>>>>>>>>> several issues with it, hoping to debug those within the >>>>>>>>>>>>>>>>>>> week >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> [1] https://github.com/ManZzup >>>>>>>>>>>>>>>>>>> /identity-entitlement-endpoint >>>>>>>>>>>>>>>>>>> [2] https://github.com/ManZzup >>>>>>>>>>>>>>>>>>> /identity-entitlement-endpoint >>>>>>>>>>>>>>>>>>> /blob/master/src/main/java/org >>>>>>>>>>>>>>>>>>> /wso2/carbon/identity/entitlem >>>>>>>>>>>>>>>>>>> ent/provider/resources/DecisionResource.java >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> On Wed, Jun 1, 2016 at 10:21 AM, Pushpalanka >>>>>>>>>>>>>>>>>>> Jayawardhana <la...@wso2.com> wrote: >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> Hi Manujith, >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> Please share the code progress via Github, once you are >>>>>>>>>>>>>>>>>>>> satisfied with refactoring. >>>>>>>>>>>>>>>>>>>> Please fork [1] to your private repo, and at location >>>>>>>>>>>>>>>>>>>> [2], you may have a new component named >>>>>>>>>>>>>>>>>>>> 'org.wso2.carbon.identity.entitlement.endpoint' >>>>>>>>>>>>>>>>>>>> where the implementation can reside. >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> [1] - https://github.com/wso2/carbon-identity-framework >>>>>>>>>>>>>>>>>>>> [2] - https://github.com/wso2/carb >>>>>>>>>>>>>>>>>>>> on-identity-framework/tree/mas >>>>>>>>>>>>>>>>>>>> ter/components/entitlement >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>>>>>>> Pushpalanka >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> On Wed, Jun 1, 2016 at 10:00 AM, Manujith Pallewatte < >>>>>>>>>>>>>>>>>>>> manujith...@gmail.com> wrote: >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> Hi all, >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> So I have roughly finished up the following 5 services >>>>>>>>>>>>>>>>>>>>> in REST >>>>>>>>>>>>>>>>>>>>> getDecision >>>>>>>>>>>>>>>>>>>>> getDecisionByAttibutes >>>>>>>>>>>>>>>>>>>>> getBooleanDecision >>>>>>>>>>>>>>>>>>>>> getEntitledAttributes >>>>>>>>>>>>>>>>>>>>> getAllEntitlements >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> The service is packed to a war file deployable to IS >>>>>>>>>>>>>>>>>>>>> 5.2.0 >>>>>>>>>>>>>>>>>>>>> It's still in primary testing, so once it's confirmed >>>>>>>>>>>>>>>>>>>>> working it will be released to the community to get their >>>>>>>>>>>>>>>>>>>>> ideas >>>>>>>>>>>>>>>>>>>>> the URIs and methods should be adjusted with the >>>>>>>>>>>>>>>>>>>>> community suggestions >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> Hoping to release the war file in coming week as well >>>>>>>>>>>>>>>>>>>>> as the code. The code have to be refracted first. >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> Thank You >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> On Mon, May 23, 2016 at 2:05 PM, Manujith Pallewatte < >>>>>>>>>>>>>>>>>>>>> manujith...@gmail.com> wrote: >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> Hi all, >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> To update on the progress so far, after having a chat >>>>>>>>>>>>>>>>>>>>>> with Pushpalanka, I started with the project code. Basic >>>>>>>>>>>>>>>>>>>>>> setups are done. >>>>>>>>>>>>>>>>>>>>>> Necessary entry points for the service was identified >>>>>>>>>>>>>>>>>>>>>> and now I'm familiar with the process of deploying the >>>>>>>>>>>>>>>>>>>>>> REST service as a >>>>>>>>>>>>>>>>>>>>>> Web app to the IS. >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> Right now, the getDecision method is implemented in a >>>>>>>>>>>>>>>>>>>>>> RESTful manner, using Apache cxf (following the >>>>>>>>>>>>>>>>>>>>>> guidelines of SCIM >>>>>>>>>>>>>>>>>>>>>> implementation as suggested by Pushpalanka and Omindu). >>>>>>>>>>>>>>>>>>>>>> The implementation >>>>>>>>>>>>>>>>>>>>>> works, yet it's only a test implementation. >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> We are expecting to consult the community on the >>>>>>>>>>>>>>>>>>>>>> actual implementation of the service, focusing on points >>>>>>>>>>>>>>>>>>>>>> like >>>>>>>>>>>>>>>>>>>>>> 1) End point URLs >>>>>>>>>>>>>>>>>>>>>> 2) Resource identification >>>>>>>>>>>>>>>>>>>>>> 3) Service method definitions >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> At the moment I'm struggling with implementations of >>>>>>>>>>>>>>>>>>>>>> some methods using the current CXF version, hoping to >>>>>>>>>>>>>>>>>>>>>> resolve it ASAP. >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>>>>>>>>> Manujith >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> On Mon, May 16, 2016 at 11:18 AM, Pushpalanka >>>>>>>>>>>>>>>>>>>>>> Jayawardhana <la...@wso2.com> wrote: >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> Hi Manujith, >>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> Good progress in getting familiar with the >>>>>>>>>>>>>>>>>>>>>>> environment. >>>>>>>>>>>>>>>>>>>>>>> So let's try to start with the scope of the project >>>>>>>>>>>>>>>>>>>>>>> too. >>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> Since we are to work on implementing REST service, >>>>>>>>>>>>>>>>>>>>>>> it is better to go through WSO2 guidelines for REST >>>>>>>>>>>>>>>>>>>>>>> service implementation. >>>>>>>>>>>>>>>>>>>>>>> Please find the white paper at[1] and the relevant >>>>>>>>>>>>>>>>>>>>>>> discussion can be found >>>>>>>>>>>>>>>>>>>>>>> at architecture mailing list under "REST API >>>>>>>>>>>>>>>>>>>>>>> Guidelines". Then we can work >>>>>>>>>>>>>>>>>>>>>>> on defining the API definition for the endpoint. >>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> You can also have a look at the existing WSO2 REST >>>>>>>>>>>>>>>>>>>>>>> implementation to capture the followed patterns >>>>>>>>>>>>>>>>>>>>>>> referring the SCIM[2] and >>>>>>>>>>>>>>>>>>>>>>> OAuth endpoints[3]. >>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> [1] - http://wso2.com/whitepapers/ >>>>>>>>>>>>>>>>>>>>>>> wso2-rest-apis-design-guidelines/ >>>>>>>>>>>>>>>>>>>>>>> [2] - https://github.com/wso2-exte >>>>>>>>>>>>>>>>>>>>>>> nsions/identity-inbound-provis >>>>>>>>>>>>>>>>>>>>>>> ioning-scim/tree/master/compon >>>>>>>>>>>>>>>>>>>>>>> ents/org.wso2.carbon.identity.scim.provider >>>>>>>>>>>>>>>>>>>>>>> [3] - https://github.com/wso2-exte >>>>>>>>>>>>>>>>>>>>>>> nsions/identity-inbound-auth-o >>>>>>>>>>>>>>>>>>>>>>> auth/tree/master/components/or >>>>>>>>>>>>>>>>>>>>>>> g.wso2.carbon.identity.oauth.endpoint >>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>>>>>>>>>> Pushpalanka >>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> On Wed, May 11, 2016 at 3:23 PM, Manujith Pallewatte >>>>>>>>>>>>>>>>>>>>>>> <manujith...@gmail.com> wrote: >>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>>> Hi Pushpalanka, >>>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>>> I managed to setup the development environment and >>>>>>>>>>>>>>>>>>>>>>>> build all the sources (thanks to Omindu :)) >>>>>>>>>>>>>>>>>>>>>>>> Then I made the PEP client using the entitlement >>>>>>>>>>>>>>>>>>>>>>>> stubs as you have mentioned in a previous thread. It's >>>>>>>>>>>>>>>>>>>>>>>> working in an >>>>>>>>>>>>>>>>>>>>>>>> accepted state. But I encountered some questions >>>>>>>>>>>>>>>>>>>>>>>> during the process, so I'm >>>>>>>>>>>>>>>>>>>>>>>> currently building a doc with all the questions so I >>>>>>>>>>>>>>>>>>>>>>>> can document them and >>>>>>>>>>>>>>>>>>>>>>>> their answers for future reference. >>>>>>>>>>>>>>>>>>>>>>>> Other than that I'm trying to write different >>>>>>>>>>>>>>>>>>>>>>>> policies using XACML >>>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>>> Also please let me know of any other steps i can >>>>>>>>>>>>>>>>>>>>>>>> follow to get familiar with the components, specially >>>>>>>>>>>>>>>>>>>>>>>> the code since I'm >>>>>>>>>>>>>>>>>>>>>>>> only focusing on Entitlement service right now >>>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>>> Thank You >>>>>>>>>>>>>>>>>>>>>>>> Manujith >>>>>>>>>>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>>> [image: Manujith Pallewatte on about.me] >>>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>>> Manujith Pallewatte >>>>>>>>>>>>>>>>>>>>>>>> about.me/manzzup >>>>>>>>>>>>>>>>>>>>>>>> <http://about.me/manzzup> >>>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>>>>>>>>> Pushpalanka. >>>>>>>>>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>>>>>>>>> Pushpalanka Jayawardhana, B.Sc.Eng.(Hons). >>>>>>>>>>>>>>>>>>>>>>> Senior Software Engineer, WSO2 Lanka (pvt) Ltd; >>>>>>>>>>>>>>>>>>>>>>> wso2.com/ >>>>>>>>>>>>>>>>>>>>>>> Mobile: +94779716248 >>>>>>>>>>>>>>>>>>>>>>> Blog: pushpalankajaya.blogspot.com/ | LinkedIn: >>>>>>>>>>>>>>>>>>>>>>> lk.linkedin.com/in/pushpalanka/ | Twitter: >>>>>>>>>>>>>>>>>>>>>>> @pushpalanka >>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> [image: Manujith Pallewatte on about.me] >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> Manujith Pallewatte >>>>>>>>>>>>>>>>>>>>>> about.me/manzzup >>>>>>>>>>>>>>>>>>>>>> <http://about.me/manzzup> >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> [image: Manujith Pallewatte on about.me] >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> Manujith Pallewatte >>>>>>>>>>>>>>>>>>>>> about.me/manzzup >>>>>>>>>>>>>>>>>>>>> <http://about.me/manzzup> >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>>>>>> Pushpalanka. >>>>>>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>>>>>> Pushpalanka Jayawardhana, B.Sc.Eng.(Hons). >>>>>>>>>>>>>>>>>>>> Senior Software Engineer, WSO2 Lanka (pvt) Ltd; >>>>>>>>>>>>>>>>>>>> wso2.com/ >>>>>>>>>>>>>>>>>>>> Mobile: +94779716248 >>>>>>>>>>>>>>>>>>>> Blog: pushpalankajaya.blogspot.com/ | LinkedIn: >>>>>>>>>>>>>>>>>>>> lk.linkedin.com/in/pushpalanka/ | Twitter: >>>>>>>>>>>>>>>>>>>> @pushpalanka >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> [image: Manujith Pallewatte on about.me] >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> Manujith Pallewatte >>>>>>>>>>>>>>>>>>> about.me/manzzup >>>>>>>>>>>>>>>>>>> <http://about.me/manzzup> >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>>>> Omindu Rathnaweera >>>>>>>>>>>>>>>>>> Software Engineer, WSO2 Inc. >>>>>>>>>>>>>>>>>> Mobile: +94 771 197 211 >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>>> Pushpalanka. >>>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>>> Pushpalanka Jayawardhana, B.Sc.Eng.(Hons). >>>>>>>>>>>>>>>>> Senior Software Engineer, WSO2 Lanka (pvt) Ltd; wso2.com/ >>>>>>>>>>>>>>>>> Mobile: +94779716248 >>>>>>>>>>>>>>>>> Blog: pushpalankajaya.blogspot.com/ | LinkedIn: >>>>>>>>>>>>>>>>> lk.linkedin.com/in/pushpalanka/ | Twitter: @pushpalanka >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>> Omindu Rathnaweera >>>>>>>>>>>>>>>> Software Engineer, WSO2 Inc. >>>>>>>>>>>>>>>> Mobile: +94 771 197 211 >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> [image: Manujith Pallewatte on about.me] >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Manujith Pallewatte >>>>>>>>>>>>>>> about.me/manzzup >>>>>>>>>>>>>>> <http://about.me/manzzup> >>>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> -- >>>>>>>>>>>>>> Pushpalanka. >>>>>>>>>>>>>> -- >>>>>>>>>>>>>> Pushpalanka Jayawardhana, B.Sc.Eng.(Hons). >>>>>>>>>>>>>> Senior Software Engineer, WSO2 Lanka (pvt) Ltd; wso2.com/ >>>>>>>>>>>>>> Mobile: +94779716248 >>>>>>>>>>>>>> Blog: pushpalankajaya.blogspot.com/ | LinkedIn: >>>>>>>>>>>>>> lk.linkedin.com/in/pushpalanka/ | Twitter: @pushpalanka >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> -- >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> [image: Manujith Pallewatte on about.me] >>>>>>>>>>>>> >>>>>>>>>>>>> Manujith Pallewatte >>>>>>>>>>>>> about.me/manzzup >>>>>>>>>>>>> <http://about.me/manzzup> >>>>>>>>>>>>> >>>>>>>>>>>>> _______________________________________________ >>>>>>>>>>>>> Dev mailing list >>>>>>>>>>>>> Dev@wso2.org >>>>>>>>>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> -- >>>>>>>>>>>> With regards, >>>>>>>>>>>> *Manu*ranga Perera. >>>>>>>>>>>> >>>>>>>>>>>> phone : 071 7 70 20 50 >>>>>>>>>>>> mail : m...@wso2.com >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> [image: Manujith Pallewatte on about.me] >>>>>>>>>>> >>>>>>>>>>> Manujith Pallewatte >>>>>>>>>>> about.me/manzzup >>>>>>>>>>> <http://about.me/manzzup> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> [image: Manujith Pallewatte on about.me] >>>>>>>>>> >>>>>>>>>> Manujith Pallewatte >>>>>>>>>> about.me/manzzup >>>>>>>>>> <http://about.me/manzzup> >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> [image: Manujith Pallewatte on about.me] >>>>>>>>> >>>>>>>>> Manujith Pallewatte >>>>>>>>> about.me/manzzup >>>>>>>>> <http://about.me/manzzup> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Omindu Rathnaweera >>>>>>>> Software Engineer, WSO2 Inc. >>>>>>>> Mobile: +94 771 197 211 >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> >>>>>>> >>>>>>> >>>>>>> [image: Manujith Pallewatte on about.me] >>>>>>> >>>>>>> Manujith Pallewatte >>>>>>> about.me/manzzup >>>>>>> <http://about.me/manzzup> >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Pushpalanka. >>>>>> -- >>>>>> Pushpalanka Jayawardhana, B.Sc.Eng.(Hons). >>>>>> Senior Software Engineer, WSO2 Lanka (pvt) Ltd; wso2.com/ >>>>>> Mobile: +94779716248 >>>>>> Blog: pushpalankajaya.blogspot.com/ | LinkedIn: lk.linkedin.com/in/p >>>>>> ushpalanka/ | Twitter: @pushpalanka >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> Dev mailing list >>>>>> Dev@wso2.org >>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Thanks & Regards, >>>>> Prabath >>>>> >>>>> Twitter : @prabath >>>>> LinkedIn : http://www.linkedin.com/in/prabathsiriwardena >>>>> >>>>> Mobile : +1 650 625 7950 >>>>> >>>>> http://facilelogin.com >>>>> >>>> >>>> >>>> >>>> -- >>>> >>>> >>>> >>>> [image: Manujith Pallewatte on about.me] >>>> >>>> Manujith Pallewatte >>>> about.me/manzzup >>>> <http://about.me/manzzup> >>>> >>> >>> >>> >>> -- >>> >>> >>> >>> Manujith Pallewatte >>> [image: https://]about.me/manzzup >>> >>> <https://about.me/manzzup?promo=email_sig&utm_source=email_sig&utm_medium=external_link&utm_campaign=chrome_ext> >>> >> >> >> >> -- >> >> >> >> Manujith Pallewatte >> [image: https://]about.me/manzzup >> >> <https://about.me/manzzup?promo=email_sig&utm_source=email_sig&utm_medium=external_link&utm_campaign=chrome_ext> >> > > > > -- > > > > Manujith Pallewatte > [image: https://]about.me/manzzup > > <https://about.me/manzzup?promo=email_sig&utm_source=email_sig&utm_medium=external_link&utm_campaign=chrome_ext> > -- Pushpalanka. -- Pushpalanka Jayawardhana, B.Sc.Eng.(Hons). Senior Software Engineer, WSO2 Lanka (pvt) Ltd; wso2.com/ Mobile: +94779716248 Blog: pushpalankajaya.blogspot.com/ | LinkedIn: lk.linkedin.com/in/ pushpalanka/ | Twitter: @pushpalanka
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
