Hi Thusitha,

On Wed, Feb 22, 2017 at 10:26 PM, Thusitha Thilina Dayaratne <
thusit...@wso2.com> wrote:

> It seems that IBM JDK doesn't contain the particular class whereas Oracle
> and OpenJDK contain the class. According to[1] we are recommending Oracle
> and Open JDK only. Therefore we may have to decide whether we should
> support IBM JDK as well.
>
> Agree with what you are saying here. However I noticed couple of issues in
the org.wso2.msf4j.util.RuntimeAnnotations class.

You are loading following classes using Class.forName() method,

sun.reflect.annotation.AnnotationInvocationHandler [1] - this is an
internal class of the JDK and we shouldn't be using this as it might
changed in a future JDK version.
java.lang.Class$Atomic [2] - this is a private inter class of the
java.lang.Class class
java.lang.Class$AnnotationData [3] - again this is a private inner class of
the java.lang.Class class


Using private/internal classes (that are not part of the public API) of the
JDK is extremely unstable as they might changed in future releases (even in
minor version releases). So, we need to figure out a way to avoid above
mentioned classes.

[1]
https://github.com/wso2/msf4j/blob/v2.1.0/core/src/main/java/org/wso2/msf4j/util/RuntimeAnnotations.java#L49
[2]
https://github.com/wso2/msf4j/blob/v2.1.0/core/src/main/java/org/wso2/msf4j/util/RuntimeAnnotations.java#L54
[3]
https://github.com/wso2/msf4j/blob/v2.1.0/core/src/main/java/org/wso2/msf4j/util/RuntimeAnnotations.java#L55

Thanks.

Thanks
> Thusitha
>
> On Wed, Feb 22, 2017 at 1:07 PM, SajithAR Ariyarathna <sajit...@wso2.com>
> wrote:
>
>> According to [2] (see "Oracle content" section) IBM JDK 8 has Nashorn in
>> it. So, UUF should work in IBM JDK :).
>>
>> Regarding your issue, According to the error log in [1] it seems like a
>> CNF problem. Log says the it cannot find "java.lang.Class$Atomic" class.
>> CNF exception is thrown from the static block in
>> org.wso2.msf4j.util.RuntimeAnnotations class [3] where
>> "java.lang.Class$Atomic" class is loaded using Class.forName() method.
>>
>> @ThusithaD, is there a workaround or a solution for this?
>>
>> [2] https://www-01.ibm.com/support/docview.wss?uid=swg21696670
>> [3] https://github.com/wso2/msf4j/blob/v2.1.0/core/src/main/
>> java/org/wso2/msf4j/util/RuntimeAnnotations.java#L54
>>
>> Thanks.
>>
>> On Wed, Feb 22, 2017 at 12:39 PM, Denuwanthi De Silva <
>> denuwan...@wso2.com> wrote:
>>
>>> Hi,
>>>
>>> When starting the IS 6.0.0 pack on top of IBM JDK 8 latest version we
>>> get the error reported at [1].
>>> The other microservices in the pack are added without an issue. I also
>>> tested a micro service sample and it works fine on ibm jdk.
>>> But when come to org.wso2.carbon.uuf.httpconnector.msf4j.UUFMicroservice
>>> it throws the reported error.
>>> After that cannot visit the User portal app as well.
>>>
>>> Are we supporting IBM jsk 8 for uuf? Any insight on this will be helpful.
>>>
>>>
>>>
>>> [1][https://wso2.org/jira/browse/IDENTITY-5762]
>>>
>>>
>>> Thanks,
>>> --
>>> Denuwanthi De Silva
>>> Senior Software Engineer;
>>> WSO2 Inc.; http://wso2.com,
>>> Email: denuwan...@wso2.com
>>> Blog: https://denuwanthi.wordpress.com/
>>>
>>
>>
>>
>> --
>> Sajith Janaprasad Ariyarathna
>> Software Engineer; WSO2, Inc.;  http://wso2.com/
>> <https://wso2.com/signature>
>>
>
>
>
> --
> Thusitha Dayaratne
> Software Engineer
> WSO2 Inc. - lean . enterprise . middleware |  wso2.com
>
> Mobile  +94712756809 <+94%2071%20275%206809>
> Blog      alokayasoya.blogspot.com
> About    http://about.me/thusithathilina
> <http://wso2.com/signature>
>
>


-- 
Sajith Janaprasad Ariyarathna
Software Engineer; WSO2, Inc.;  http://wso2.com/
<https://wso2.com/signature>
_______________________________________________
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Reply via email to