Hi Bhathiya, On Fri, Jun 2, 2017 at 12:14 AM, Bhathiya Jayasekara <bhath...@wso2.com> wrote:
> Hi all, > > While using current DCR API of IS I observed a few things that might need > an improvement or should be fixed. > > 1) When I create 2 apps with the same "client_name", it returns the same > app with "201:Created" response. Shouldn't it throw an error saying > "client_name" already exists? > This is already identified and fixed IDENTITY-5529 > 2) We have to provide at least 1 Redirect URL in DCR request. Shouldn't > "redirect_urls" be optional, as grant types like "password" don't need it > at all? > With the current implementation OAuth App registration we expect this, So in the DCR layer we can't make this optional. In the registration it can send some value. So I think this is ok. -Ishara > > Thanks, > Bhathiya > > On Thu, May 25, 2017 at 5:43 PM, Abilashini Thiyagarajah < > abilashini...@cse.mrt.ac.lk> wrote: > >> Hi, >> >> I have sent a PR [1] with the completed parts. Please review. >> >> [1] https://github.com/wso2-extensions/identity-inbound-auth >> -oauth/pull/373 >> >> Thanks, >> Abilashini >> >> *Thiyagarajah Abilashini* >> Student >> Department of Computer Science and Engineering >> University of Moratuwa, Sri Lanka >> >> On 25 May 2017 at 15:27, Pushpalanka Jayawardhana <la...@wso2.com> wrote: >> >>> Hi Abilashini, >>> >>> As per the discussion we had short while ago, let's prioritize >>> implementing the APIs required for DCRM functionality. >>> >>> Support for multiple locales in not a critical requirement for us at the >>> moment, hence moved that to a separate task as at [1]. You can add your >>> current findings there so we can later attend that. >>> You can send a PR for current progress for the issue, so that you can >>> start working on DCRM. >>> >>> [1] - https://wso2.org/jira/browse/IDENTITY-5979 >>> >>> Thanks, >>> Pushpalanka >>> >>> On Thu, May 25, 2017 at 10:50 AM, Abilashini Thiyagarajah < >>> abilashini...@cse.mrt.ac.lk> wrote: >>> >>>> Hi Pushpalanka, >>>> >>>> Thanks for your reply. I have already referred this section to >>>> understand the concept. But in the specific issue, it has been mentioned >>>> only for redirect URI. >>>> >>>> To consider local specific values for all the Human-readable client >>>> metadata, can we fix it as a separate issue rather than including it in the >>>> [1]. >>>> >>>> The problems arise on fixing this are, >>>> >>>> 1. If there are local specific values for redirect uris, should it >>>> be added to the typical redirect uris list when building the >>>> registration >>>> request object. >>>> 2. If there are multiple values for a specific meta data (eg. >>>> client_name) in different languages, then which to be considered during >>>> registration. >>>> >>>> I found a library [2] which supports for language tags. Can we use it >>>> for the implementation? >>>> >>>> [1] https://wso2.org/jira/browse/IDENTITY-5879 >>>> [2] https://www.connect2id.com/blog/language-tags-rfc-5646-for-java >>>> >>>> Thanks, >>>> Abilashini >>>> >>>> *Thiyagarajah Abilashini* >>>> Student >>>> Department of Computer Science and Engineering >>>> University of Moratuwa, Sri Lanka >>>> >>>> On 25 May 2017 at 09:54, Pushpalanka Jayawardhana <la...@wso2.com> >>>> wrote: >>>> >>>>> Hi Abilashini, >>>>> >>>>> This section in the specification elaborates more in this[1]. >>>>> This is not limited to redirect URI, but for all Human-readable client >>>>> metadata. >>>>> >>>>> [1] - https://tools.ietf.org/html/rfc7591#section-2.2 >>>>> >>>>> Thanks, >>>>> Pushpalanka >>>>> >>>>> On Tue, May 23, 2017 at 2:09 PM, Abilashini Thiyagarajah < >>>>> abilashini...@cse.mrt.ac.lk> wrote: >>>>> >>>>>> Hi all, >>>>>> >>>>>> I am currently working on the issue [1]. Specifically the point 4 in >>>>>> the description, it has been mentioned as the implementation should allow >>>>>> multiple locale-specific values for redirect URI. According to my >>>>>> understanding on the implementation of DCR, if there are any >>>>>> locale-specific values for the redirect URI in the registration request >>>>>> (eg. redirect_uris#en), it will be added to the list of redirect >>>>>> URI's while building the registration request profile. Is that the >>>>>> expected >>>>>> outcome? Please provide your insights. >>>>>> >>>>>> [1] https://wso2.org/jira/browse/IDENTITY-5879 >>>>>> >>>>>> >>>>>> *Thiyagarajah Abilashini* >>>>>> Student >>>>>> Department of Computer Science and Engineering >>>>>> University of Moratuwa, Sri Lanka >>>>>> >>>>>> On 15 May 2017 at 23:51, Maduranga Siriwardena <madura...@wso2.com> >>>>>> wrote: >>>>>> >>>>>>> Thanks Abilashini for the PR. We will review and merge. >>>>>>> >>>>>>> In the mean time, please work on the other issue too. >>>>>>> >>>>>>> On Fri, May 12, 2017 at 1:30 PM, Abilashini Thiyagarajah < >>>>>>> abilashini...@cse.mrt.ac.lk> wrote: >>>>>>> >>>>>>>> Hi all, >>>>>>>> >>>>>>>> Please review - https://github.com/wso2-exte >>>>>>>> nsions/identity-inbound-auth-oauth/pull/353 >>>>>>>> >>>>>>>> Best Regards, >>>>>>>> Abilashini >>>>>>>> >>>>>>>> *Thiyagarajah Abilashini* >>>>>>>> Student >>>>>>>> Department of Computer Science and Engineering >>>>>>>> University of Moratuwa, Sri Lanka >>>>>>>> >>>>>>>> On 10 May 2017 at 15:54, Abilashini Thiyagarajah < >>>>>>>> abilashini...@cse.mrt.ac.lk> wrote: >>>>>>>> >>>>>>>>> Hi Dimuthu, >>>>>>>>> >>>>>>>>> Thank you for sharing these informative sources. >>>>>>>>> >>>>>>>>> Best Regards, >>>>>>>>> >>>>>>>>> *Thiyagarajah Abilashini* >>>>>>>>> Student >>>>>>>>> Department of Computer Science and Engineering >>>>>>>>> University of Moratuwa, Sri Lanka >>>>>>>>> >>>>>>>>> On 10 May 2017 at 13:45, Dimuthu De Lanerolle <dimut...@wso2.com> >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>>> Hi Abilashini, >>>>>>>>>> >>>>>>>>>> I have attached some info links with might be useful to you. >>>>>>>>>> >>>>>>>>>> [1] https://docs.wso2.com/display/IS530/OpenID+Connect+Dynam >>>>>>>>>> ic+Client+Registration >>>>>>>>>> [2] http://openid.net/specs/openid-connect-registration-1_0.html >>>>>>>>>> [3] Doc Attached. Also you may find more info related to DCR >>>>>>>>>> requests and responses using previous JIra (eg: IDENTITY-5436, >>>>>>>>>> IDENTITY-5435 >>>>>>>>>> etc.) >>>>>>>>>> >>>>>>>>>> Regards >>>>>>>>>> DimuthuD >>>>>>>>>> >>>>>>>>>> On Wed, May 10, 2017 at 12:59 PM, Abilashini Thiyagarajah < >>>>>>>>>> abilashini...@cse.mrt.ac.lk> wrote: >>>>>>>>>> >>>>>>>>>>> Hi Maduranga, >>>>>>>>>>> >>>>>>>>>>> I will work on it and get back to you soon. >>>>>>>>>>> >>>>>>>>>>> Thanks, >>>>>>>>>>> >>>>>>>>>>> *Thiyagarajah Abilashini* >>>>>>>>>>> Student >>>>>>>>>>> Department of Computer Science and Engineering >>>>>>>>>>> University of Moratuwa, Sri Lanka >>>>>>>>>>> >>>>>>>>>>> On 9 May 2017 at 09:16, Maduranga Siriwardena < >>>>>>>>>>> madura...@wso2.com> wrote: >>>>>>>>>>> >>>>>>>>>>>> Hi Abilashini, >>>>>>>>>>>> >>>>>>>>>>>> As discussed can you start working on [1] and [2] to improve >>>>>>>>>>>> the existing DCR functionality. If you need any clarification or >>>>>>>>>>>> help, >>>>>>>>>>>> please get back to us. >>>>>>>>>>>> >>>>>>>>>>>> [1] https://wso2.org/jira/browse/IDENTITY-5529 >>>>>>>>>>>> [2] https://wso2.org/jira/browse/IDENTITY-5185 >>>>>>>>>>>> >>>>>>>>>>>> Thanks, >>>>>>>>>>>> -- >>>>>>>>>>>> Maduranga Siriwardena >>>>>>>>>>>> Senior Software Engineer >>>>>>>>>>>> WSO2 Inc; http://wso2.com/ >>>>>>>>>>>> >>>>>>>>>>>> Email: madura...@wso2.com >>>>>>>>>>>> Mobile: +94718990591 <+94%2071%20899%200591> >>>>>>>>>>>> Blog: *https://madurangasiriwardena.wordpress.com/ >>>>>>>>>>>> <https://madurangasiriwardena.wordpress.com/>* >>>>>>>>>>>> <http://wso2.com/signature> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> _______________________________________________ >>>>>>>>>>> Dev mailing list >>>>>>>>>>> Dev@wso2.org >>>>>>>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Dimuthu De Lanerolle >>>>>>>>>> Software Engineer >>>>>>>>>> WSO2 Inc. >>>>>>>>>> lean . enterprise . middlewear. >>>>>>>>>> http://wso2.com/ >>>>>>>>>> Tel. : +94 11 2145345 <011%202%20145345> Fax : +94 11 2145300 >>>>>>>>>> <011%202%20145300> email : dimut...@wso2.com >>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Maduranga Siriwardena >>>>>>> Senior Software Engineer >>>>>>> WSO2 Inc; http://wso2.com/ >>>>>>> >>>>>>> Email: madura...@wso2.com >>>>>>> Mobile: +94718990591 <+94%2071%20899%200591> >>>>>>> Blog: *https://madurangasiriwardena.wordpress.com/ >>>>>>> <https://madurangasiriwardena.wordpress.com/>* >>>>>>> <http://wso2.com/signature> >>>>>>> >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> Dev mailing list >>>>>> Dev@wso2.org >>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Pushpalanka. >>>>> -- >>>>> Pushpalanka Jayawardhana, B.Sc.Eng.(Hons). >>>>> Senior Software Engineer, WSO2 Lanka (pvt) Ltd; wso2.com/ >>>>> Mobile: +94779716248 >>>>> Blog: pushpalankajaya.blogspot.com/ | LinkedIn: lk.linkedin.com/in/p >>>>> ushpalanka/ | Twitter: @pushpalanka >>>>> >>>>> >>>> >>> >>> >>> -- >>> Pushpalanka. >>> -- >>> Pushpalanka Jayawardhana, B.Sc.Eng.(Hons). >>> Senior Software Engineer, WSO2 Lanka (pvt) Ltd; wso2.com/ >>> Mobile: +94779716248 >>> Blog: pushpalankajaya.blogspot.com/ | LinkedIn: lk.linkedin.com/in/p >>> ushpalanka/ | Twitter: @pushpalanka >>> >>> >> >> _______________________________________________ >> Dev mailing list >> Dev@wso2.org >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > > > -- > *Bhathiya Jayasekara* > *Associate Technical Lead,* > *WSO2 inc., http://wso2.com <http://wso2.com>* > > *Phone: +94715478185 <+94%2071%20547%208185>* > *LinkedIn: http://www.linkedin.com/in/bhathiyaj > <http://www.linkedin.com/in/bhathiyaj>* > *Twitter: https://twitter.com/bhathiyax <https://twitter.com/bhathiyax>* > *Blog: http://movingaheadblog.blogspot.com > <http://movingaheadblog.blogspot.com/>* > -- Ishara Karunarathna Associate Technical Lead WSO2 Inc. - lean . enterprise . middleware | wso2.com email: isha...@wso2.com, blog: isharaaruna.blogspot.com, mobile: +94717996791
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
