Yes, normalizing indentation is a fine thing, though honestly arguing for it is almost as archaic as arguing against it. Tools should let people work with whatever styles they prefer while focusing on content. It's not as if any of us are still debugging from printouts.
120 columns: Even now, not everyone likes wide windows. I'll consider it, but this really strikes me as akin to the quibbles about bracket placement. A professional should be able to comfortably read almost any common code style, and if I can tolerate occasional wrapped lines or side-scrolling I really think others can tolerate my avoiding those. If there is an official Apache style guidelines which says we SHOULD NOT write shorter lines I haven't seen it yet. And realistically, the number of lines that would actually be changed in these files is miniscule. -- /_ Joe Kesselman (he/him/his) -/ _) My Alexa skill for New Music/New Sounds fans: / https://www.amazon.com/dp/B09WJ3H657/ () I still don't think HTML mail is a good idea /\ but Outlook/Android is insisting. Need to change mail client. ________________________________ From: kriegaex (via GitHub) <[email protected]> Sent: Monday, November 13, 2023 11:04:37 PM To: [email protected] <[email protected]> Subject: [PR] Reformat Maven POMs, no functional changes [xalan-java] kriegaex opened a new pull request, #120: URL: https://github.com/apache/xalan-java/pull/120 - Get rid of mixed tabs and spaces, use 2 spaces for indentation uniformly instead. - Use line width 120 with very few exceptions. - Use a uniform way to format multi-line XML comments, putting opening and closing tag parts on separate lines, indenting the text content by 2 spaces. This can subsequently be the baseline for further commits, both by @kubycsolutions and external PR contributors. Sorry for maybe seeming nitpicky, but when scrolling through the POMs in my IDE, it seemed somewhat messy and hard to parse in my limited brain. It might be a personal preference only, but I do like uniform indentation. As the Java code mostly seems to use 2 spaces and the POMs also partly followed that pattern, I chode 2 spaces too - maybe also, because that is my personal preference. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
