kubycsolutions commented on PR #120:
URL: https://github.com/apache/xalan-java/pull/120#issuecomment-1809576966
I think my conclusion right now is: normalized indentation to spaces only
and 2-column steps is accepted as a definite improvement.
Increasing line length by 50% as a general practice I'm reserving judgement
on, especially when the entire Xalan codebase is styled to lines of about 80
characters. If folks want to write long lines, then as long as they're
reasonably readable I won't object; if they incidentally restyle as part of a
substantive change, ditto (as long as they're willing to extend me the same
courtesy). But I'm not yet seeing a need to force a change before it happens
organically.
You _do_ realize that the reason for reducing indentation stops from 8
spaces to 4 to less was to better fit 80-column terminals and narrower windows,
right? Asking for both that and longer lines is a touch inconsistent
historically. But de gustibus non disputandum est, and coding style beyond
basic legibility is definitely a matter of taste. I can work with almost
anything except the guy who insisted that in his C code semicolon went before
the start of a statement rather than at its end.
--
/_ Joe Kesselman (he/him/his)
-/ _) My Alexa skill for New Music/New Sounds fans:
/ https://www.amazon.com/dp/B09WJ3H657/
() I still don't think HTML mail is a good idea
/\ but Outlook/Android is insisting. Need to
change mail client.
________________________________
From: Alexander Kriegisch ***@***.***>
Sent: Monday, November 13, 2023 11:04:44 PM
To: apache/xalan-java ***@***.***>
Cc: Joseph Kesselman ***@***.***>; Mention ***@***.***>
Subject: [apache/xalan-java] Reformat Maven POMs, no functional changes (PR
#120)
* Get rid of mixed tabs and spaces, use 2 spaces for indentation
uniformly instead.
* Use line width 120 with very few exceptions.
* Use a uniform way to format multi-line XML comments, putting opening
and closing tag parts on separate lines, indenting the text content by 2 spaces.
This can subsequently be the baseline for further commits, both by
@kubycsolutions<https://github.com/kubycsolutions> and external PR contributors.
Sorry for maybe seeming nitpicky, but when scrolling through the POMs in my
IDE, it seemed somewhat messy and hard to parse in my limited brain. It might
be a personal preference only, but I do like uniform indentation. As the Java
code mostly seems to use 2 spaces and the POMs also partly followed that
pattern, I chode 2 spaces too - maybe also, because that is my personal
preference.
________________________________
You can view, comment on, or merge this pull request online at:
https://github.com/apache/xalan-java/pull/120
Commit Summary
*
816d616<https://github.com/apache/xalan-java/pull/120/commits/816d6163797fd0a7da3a099112c67bc1b6dc4ec6>
Reformat Maven POMs, no functional changes
File Changes
(6 files<https://github.com/apache/xalan-java/pull/120/files>)
* M
distribution/pom.xml<https://github.com/apache/xalan-java/pull/120/files#diff-ac19e9d7369629bf473b9b6c514012d5fecc319f98a6b9b57855f3202e970610>
(30)
* M
pom.xml<https://github.com/apache/xalan-java/pull/120/files#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8>
(402)
* M
samples/pom.xml<https://github.com/apache/xalan-java/pull/120/files#diff-eb8baa2a7ef27be22bc6fa693b229395e6ae824a95ccde07202d8d97b91f7740>
(89)
* M
serializer/pom.xml<https://github.com/apache/xalan-java/pull/120/files#diff-2cb43b87715a28c31056f717bee375907a7d6b05db40dd14899346909d1662d5>
(92)
* M
xalan/pom.xml<https://github.com/apache/xalan-java/pull/120/files#diff-8fc15af17bf692a644c8fc77eb847323a47d0803f45aac0952255b991195fcbe>
(150)
* M
xalan2jtaglet/pom.xml<https://github.com/apache/xalan-java/pull/120/files#diff-de7f09ef626f3db137f8fb539236aab2a328faea4ad18322f3054b376cb66aa1>
(103)
Patch Links:
* https://github.com/apache/xalan-java/pull/120.patch
* https://github.com/apache/xalan-java/pull/120.diff
—
Reply to this email directly, view it on
GitHub<https://github.com/apache/xalan-java/pull/120>, or
unsubscribe<https://github.com/notifications/unsubscribe-auth/AOKT7A4MPEFP7TINCLGWRITYELUVZAVCNFSM6AAAAAA7KFDX4WVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE4TCOJUHA4DSMI>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
