vlsi commented on PR #124: URL: https://github.com/apache/xalan-java/pull/124#issuecomment-1818810251
> That was intentional Please be civil. You asked me the reason I was not interested, I replied, and now you say you get annoyed by my statements. Look: I have a great amount of Maven experience, I submitted PRs and issues there, and I just responded to your question of why reviewing Maven scripts is a waste of time for me. Once again, be civil, and stop accusing others. As you stress that "...build process. Any change can mess up the build. Reviewing them is well invested time", please check out https://github.com/apache/xalan-java/pull/2 and my other PRs to xalan-java. They are all build-related. > No, you said it was a waste of time. That is a judgemental statement Sure reviewing Maven scripts is a waste of time for me. Sure there might be people who adore reviewing Maven scripts. It does not mean "Maven is crap" or "Maven is good". It just means I do not like spending time on reviewing Maven scripts. > you see that I am open for criticism, having taken your concerns about package relocation seriously and addressing them here, even though you bluntly just suggested to decline the PR. First, thank you for figuring out the way properties file can be relocated. Second, I would stress that you did not envision issues with META-INF/maven usages in the first place, and it was me who highlighted the issues with relocation. If the original solution with META-INF/maven was merged as is, then it would likely cause issues for the end users. A design issue was identified during a review, and you fixed it. That is the way review should work in my opinion. What else do you expect from a code/design review? I believe my comment on the possibility of shade/relocate issues was constructive as I suggested a relevant case that should be tested for your change. At the same time, your issue XALANJ-2710 did not include the motivation in the first place. It is surprising to see "feature X to be implemented as Y" with no motivation. Sure there must be some motivation behind every change since every change might introduce bugs. It would be great if you included the motivation for the changes the next time you create issues. See http://stronglyemergent.com/blog/2013/negative-100-points/ on the reasons why it might be a good idea to resist including every possible change. It is too late to fix bugs in the released software, so you probably want identifying the issues before you release rather than try to solve all the problems after the release. > some people find a solution for every problem and others a problem in every solution Frankly, why not both? You seem to assume that people should split into either of those categories, while in practice both skills "finding solutions" and "finding problems" are mandatory. The skill of "problem in every solution" is just a skill of testing. So, I would suggest you put some more context into your "some people find a solution for every problem and others a problem in every solution" joke or otherwise it sounds like "testing skill is not needed". I see you keep repeating "I am always trying to find a problem in every solution". Frankly speaking > you see that I am open for criticism > having to read utterly unhelpful statements Frankly speaking, I find this statement utterly unhelpful. It looks like you accuse me of spamming with irrelevant comments while I am sure my comments were helpful. It would be really helpful (no joke) if you could explain which of my statements were "utterly unhelpful". Please be exact. > all in the gist of "Gradle is great, Maven is crap" (paraphrasing the vibe I got when reading them). I am afraid you misinterpret. Sure everybody is free to have the fun they like. As people select Maven, they are free to have fun with it. At no point in time I said "Gradle is great, Maven is crap". I am afraid it is a vibe you might have taken from somewhere else. [I was always open to help with migrating to Gradle](https://github.com/apache/xalan-java/pull/105#issuecomment-1771427122). Sure people can ignore it, however, it is unfair of you to say I am not constructive. I explained the reasons I do not want spending my time on Maven, please just recognize it and stop accusing me of raising "Gradle vs Maven". You want Maven, fine. Just go for it. At the same time, please stop judging others if they happen to dislike Maven. @kriegaex , I suggest you to check the following: * https://issues.apache.org/jira/issues/?jql=project%20%3D%20XALANJ%20AND%20reporter%3Dvladimirsitnikov%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC * https://github.com/apache/xalan-java/pulls?q=author%3Avlsi+ * https://lists.apache.org/[email protected]:lte=10y:sitnikov I am sure all of it is constructive, and they are nowhere near "Gradle is great, Maven is crap" you mention. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
