kriegaex commented on PR #124: URL: https://github.com/apache/xalan-java/pull/124#issuecomment-1820131213
> > That was intentional > > Please be civil. I was and still am civil. It should be permitted for me to speak just as frankly as you do. It is quite interesting to see that you are always ready to deal blows, but seem to be unwilling to take any in response. Like I said: Be nice to me, and I will be nice to you. Tit for tat. You were not nice, but repeatedly made snarky, even condescending comments like Maven being a "waste of time". > As you stress that "...build process. Any change can mess up the build. Reviewing them is well invested time", please check out #2 and my other PRs to xalan-java. They are all build-related. I am talking about our interaction here, not about whatever other PRs - build-related or not - you might have worked on before. They are utterly irrelevant here and in no way entitle you to make dismissive comments and then be surprised about confrontative responses. Again: tit for tat. > > No, you said it was a waste of time. That is a judgemental statement > > Sure reviewing Maven scripts is a waste of time for me. Sure there might be people who adore reviewing Maven scripts. It does not mean "Maven is crap" or "Maven is good". It just means I do not like spending time on reviewing Maven scripts. Then I suggest, that you choose your wording more carefully next time. Out of context, the comment is most likely to be understood as judgemental, snarky, condescending - especially, if you follow up both here and on Jira with Maven vs. Gradle comparisons. You do not need to "adore" Maven or the people using it. Just do not look down on them. You are in no way superior or more advanced, because you happen to prefer Gradle. > > you see that I am open for criticism, having taken your concerns about package relocation seriously and addressing them here, even though you bluntly just suggested to decline the PR. > > First, thank you for figuring out the way properties file can be relocated. Second, I would stress that you did not envision issues with META-INF/maven usages in the first place, and it was me who highlighted the issues with relocation. Which is why I thanked you, even burnt into the commit history forever. But your first comment on the Jira issue was to suggest unconditionally decline and close it.  Do you even notice how condescending you treat other people? Try that with others, but not with me, I am not having it. Or live with the way I respond. I had to protest first, before you finally made more helpful comments, and only then this happened: > If the original solution with META-INF/maven was merged as is, then it would likely cause issues for the end users. A design issue was identified during a review, and you fixed it. That is the way review should work in my opinion. What else do you expect from a code/design review? Then why don't you start with that kind of review next time? Skipping the rest of your comments, because my time box is up. I already regret answering this much, because I actually I do not want to read twice the amount as a response from you, feeling compelled to reply once more. Instead, I would like to continue helping Joe here and there with his Maven migration. You can either join us or let us work in peace. There is no need for you to "waste your time" with more Maven-related things. Helpful code reviews are always welcome, though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
