yangwwei commented on a change in pull request #1:
URL:
https://github.com/apache/incubator-yunikorn-release/pull/1#discussion_r425003057
##########
File path: helm-charts/index.yaml
##########
@@ -0,0 +1,14 @@
+# TODO: update this file after releasing the chart
Review comment:
pls include apache license header
##########
File path: helm-charts/yunikorn/.helmignore
##########
@@ -0,0 +1,21 @@
+# Patterns to ignore when building packages.
Review comment:
add apache license header
##########
File path: helm-charts/yunikorn/templates/deployment.yaml
##########
@@ -0,0 +1,74 @@
+apiVersion: apps/v1beta2
Review comment:
add apache license header
##########
File path: helm-charts/index.yaml
##########
@@ -0,0 +1,14 @@
+# TODO: update this file after releasing the chart
+apiVersion: v1
+entries:
+ yunikorn:
+ - apiVersion: v1
+ appVersion: 0.1.0
Review comment:
what does the appVersion mean here?
how is it related to the release version?
##########
File path: helm-charts/yunikorn/templates/configmap.yaml
##########
@@ -0,0 +1,14 @@
+apiVersion: v1
Review comment:
add apache license header
##########
File path: helm-charts/yunikorn/templates/rbac.yaml
##########
@@ -0,0 +1,24 @@
+apiVersion: v1
Review comment:
apache license
##########
File path: helm-charts/yunikorn/templates/service.yaml
##########
@@ -0,0 +1,23 @@
+apiVersion: v1
Review comment:
apache license
##########
File path: helm-charts/yunikorn/templates/cleanup.yaml
##########
@@ -0,0 +1,37 @@
+apiVersion: batch/v1
Review comment:
add apache license header
##########
File path: helm-charts/yunikorn/values.yaml
##########
@@ -0,0 +1,98 @@
+# This is a YAML-formatted file.
Review comment:
apache license
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
