wilfred-s commented on pull request #1:
URL: 
https://github.com/apache/incubator-yunikorn-release/pull/1#issuecomment-629027456


   I am a huge +1 on removing the helm charts from the k8shim. I have created 
YUNIKORN-159 to remove the files and update the documentation when this is done.
   
   I don't think building the images needs to move. This is just about pushing 
the images and the helm charts on release. The Makefile will still be there to 
generate the images. You can have a copy of the helm charts locally if you want 
to use that 
   
   What I am currently missing is the integration into the release process. I 
assume that we will only push new helm charts when we release a new version. 
That means the tool for building a release needs to be adjusted to generate the 
new chart for a release.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to