GitHub user khalidhuseynov opened a pull request:
https://github.com/apache/zeppelin/pull/1007
Update and refactor NotebookRepo versioning API
### What is this PR for?
This is firstly to refactor API for versioning and keep everthing inside of
one interface (NotebookRepo) instead of two different interfaces
(NotebookRepoVersioned). Secondly, there're modifications to existing
versioning api, with considerations of future complete implementation of
versioning. Note that this PR doesn't implement all suggested interfaces, but
lays foundation for their implementation.
### What type of PR is it?
Improvement && Refactoring
### Todos
* [x] - move versioning api (get, history) from NotebookRepoVersioned to
NotebookRepo
* [x] - refactor and naming changes
* [x] - modify checkpoint api (add return value) and modify
NotebookRepoSync to deal with it
* [ ] - address comments
### What is the Jira issue?
### How should this be tested?
Basically it doesn't add new functionality, so the only requirement is for
tests to pass.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? not breaking, but some api
changes
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/incubator-zeppelin
repo/versioning-api-update
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1007.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1007
----
commit faf1b5b06a0753fa728caec7579f1bb6118137ae
Author: Khalid Huseynov <khalid...@nflabs.com>
Date: 2016-06-13T22:10:03Z
move and update versioning api
first of all versioning api was moved into NotebookRepo to keep all api in
one place, secondly it was updated with Rev class referring to revision unit
commit 3dce38bcd4b7a1eeb110e336d069527028a7429c
Author: Khalid Huseynov <khalid...@nflabs.com>
Date: 2016-06-13T22:14:12Z
propagate changes to all repos
commit 1ec67e648afb39cbc50ba1b98824c8a86e70828a
Author: Khalid Huseynov <khalid...@nflabs.com>
Date: 2016-06-13T22:14:46Z
apply changes to NotebookRepoSync
commit ee1eeb3357af4a051625d7058819c7e3aad3be8d
Author: Khalid Huseynov <khalid...@nflabs.com>
Date: 2016-06-13T22:15:24Z
fix tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
