Github user bzz commented on the issue:

    https://github.com/apache/zeppelin/pull/1007
  
    Good point, if asked, I would say that having `NotebookRepoSync implements 
NotebookRepo` is not an elegant design either - NotebookRepoSync is not a 
NoteboksRepo! :)
    
    It's up to you after all, I see that you feel it's the best way to 
integrate for now and is as good as it can be - so let's keep it like this. It 
can always be refactored later on.
    
    Looks good to me, will merge if there is no other discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to