Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/1333
  
    @zjffdu Tested and It looks good to me.
    
    There is an unittest for set environment variable for remote interpreter at 
[RemoteInterpreterTest.java](https://github.com/apache/zeppelin/blob/master/zeppelin-interpreter/src/test/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterTest.java#L721).
 However, the unit test is not testing the case this fix addresses.
    
    It's not going to be a blocker but I think it'll be really beneficial to 
have a unittest that covers this fix, somewhere in 
[InterpreterFactoryTest.java](https://github.com/apache/zeppelin/blob/master/zeppelin-interpreter/src/test/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterTest.java).
 @zjffdu Is it going to be difficult to add the test?  Let me know if you need 
any help!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to