GitHub user zjffdu reopened a pull request:
https://github.com/apache/zeppelin/pull/1333
[ZEPPELIN-1334] Environment variable defined in interpreter setting doesn't
take effect
### What is this PR for?
I define SPAKR_HOME in interpreter setting, but it doesn't take effect.
This PR is for bring back the environment variable defined in interpreter
setting. The root cause is that we reset the env after creating
RemoteInterpreter.
```
new RemoteInterpreter(property, noteId, className,
conf.getInterpreterRemoteRunnerPath(),
interpreterPath, localRepoPath, connectTimeout, maxPoolSize,
remoteInterpreterProcessListener, appEventListener);
remoteInterpreter.setEnv(env);
```
### What type of PR is it?
[Bug Fix]
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1334
### How should this be tested?
Tested manually. Create 2 spark interpreter setting, one for spark1
another is for spark2. And define SPARK_HOME for each interpreter. Then I can
run both spark1 and spark2 in one zeppelin instance.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1334
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1333.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1333
----
commit 3e7c1fabf364c8b6cfcb2b28fcfac0618cfb36aa
Author: Jeff Zhang <zjf...@apache.org>
Date: 2016-08-16T10:16:58Z
[ZEPPELIN-1334] Environment variable defined in interpreter setting doesn't
take effect
commit 50934a00ecd44a6d17ffaa5967f9ab7aadfcbb2f
Author: Jeff Zhang <zjf...@apache.org>
Date: 2016-08-19T06:20:01Z
add test case
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
