GitHub user soralee opened a pull request:

    https://github.com/apache/zeppelin/pull/1804

    [ZEPPELIN-1578] notes list in customizing zeppelin homepage isn't working

    ### What is this PR for?
    Customizing the Zeppelin Homepage to show the notebook list does not work 
as [0.6.2 
document](http://zeppelin.apache.org/docs/0.6.2/manuala/notebookashomepage.html#show-notebooks-list-in-your-custom-homepage).
 Furthermore, it is not working on 0.7.0 version ([0.7.0 
document](http://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/manual/notebookashomepage.html#show-notes-list-in-your-custom-homepage)).
 
    
    That reason is that get_home message of zeppelin websocket is called in 
zeppelin-web twice.
    
    At this chance, I suggest to split role to HomeCtrl and CustomHomeCtrl. 
because when "Home.controller.js" is update, It could be conflicted like 
current issue.
    So I think it would be more convenient to manage the roles separately.
    
    
    
    ### What type of PR is it?
    [Bug Fix |  Feature | Documentation ]
    
    ### Todos
    * None
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-1578
    
    ### How should this be tested?
    - After write the following code in paragraph, run it.
    ```
    println(
    """%angular
      <div ng-include="'app/home/customer/customHome.html'"></div>
    """)
    ```
    
    ### Screenshots (if appropriate)
    
![homepage_custom_notebook_list](https://cloud.githubusercontent.com/assets/8110458/21465904/e9e7deea-c9f8-11e6-8c97-bcc145479e31.png)
    
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? Yes


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/soralee/zeppelin ZEPPELIN-1578

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1804.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1804
    
----
commit c1cfe6b84828cecb5df64cd59b28d24f49968b72
Author: soralee <sora0...@nflabs.com>
Date:   2016-12-23T06:36:53Z

    notes list in custom homepage isn't working

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to