GitHub user soralee reopened a pull request:

    https://github.com/apache/zeppelin/pull/1804

    [ZEPPELIN-1578] notes list in customizing zeppelin homepage isn't working

    ### What is this PR for?
    Customizing the Zeppelin Homepage to show the notebook list does not work 
as [0.6.2 
document](http://zeppelin.apache.org/docs/0.6.2/manuala/notebookashomepage.html#show-notebooks-list-in-your-custom-homepage).
 Furthermore, it is not working on 0.7.0 version ([0.7.0 
document](http://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/manual/notebookashomepage.html#show-notes-list-in-your-custom-homepage)).
 
    
    That reason is that get_home message of zeppelin websocket is called in 
zeppelin-web twice.
    
    At this chance, I suggest to split role to HomeCtrl and CustomHomeCtrl 
because when "Home.controller.js" is update, It could be conflicted like 
current issue.
    So I think it would be more convenient to manage the roles separately.
    
    
    
    ### What type of PR is it?
    [Bug Fix |  Feature | Documentation ]
    
    ### Todos
    * None
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-1578
    
    ### How should this be tested?
    - After write the following code in paragraph, run it.
    ```
    println(
    """%angular
      <div ng-include="'app/home/customer/customHome.html'"></div>
    """)
    ```
    
    ### Screenshots (if appropriate)
    
![homepage_custom_notebook_list](https://cloud.githubusercontent.com/assets/8110458/21465904/e9e7deea-c9f8-11e6-8c97-bcc145479e31.png)
    
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? Yes


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/soralee/zeppelin ZEPPELIN-1578

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1804.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1804
    
----
commit 2c23aa214959ac8f0a75f87f5da538de2cf55fd8
Author: soralee <sora0...@nflabs.com>
Date:   2016-12-23T06:36:53Z

    notes list in custom homepage isn't working

commit 65db7c59f39c5c39e0873d1db6f0821bdfcdd15a
Author: soralee <sora0...@nflabs.com>
Date:   2016-12-27T11:15:16Z

    fix to show text after searching note

commit ade61701948c101b367b1d2444997c71ae323a6e
Author: soralee <sora0...@nflabs.com>
Date:   2016-12-29T08:14:18Z

    rebase master

commit 754388399dc062d164b84d6fcca7f87e56091fc4
Author: soralee <sora0...@nflabs.com>
Date:   2017-01-10T03:39:59Z

    improve customer hompage

commit cac09aa1a13b9994cd004ed187652a4f8d7b8efc
Author: soralee <sora0...@nflabs.com>
Date:   2017-01-10T03:49:26Z

    remove file

commit 4676d8663948089f08f25c6517269df9dad114e6
Author: soralee <sora0...@nflabs.com>
Date:   2017-01-10T03:53:49Z

    remove old img file

commit fe86abb29b0f752256e6646f87dc3208ecf4fce1
Author: soralee <sora0...@nflabs.com>
Date:   2017-01-10T04:16:39Z

    apply homepage template

commit 57d501ce2c7883d13656d30054b1e91dd6149338
Author: soralee <sora0...@nflabs.com>
Date:   2017-01-10T05:04:55Z

    for rebase it

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to