[GitHub] zeppelin issue #2120: [ZEPPELIN-1492] fixing the issue where updating a para...

[1ambda]

Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2120
  
    @FRosner Sorry for late reply. 😭... 
    
    ### I can't reproduce the original issue reported in 1492 in current master
    
    Usually, paragraph will be updated If interpreter updates paragraph object 
properly for example `dataFinished`. 
    I am not sure there is an case when **other paragraph fields are exactly 
same and only `paragraph.text` is different**. Only in this case, paragraph 
will be not updated in current implementation. 
    
    ```js
    // 
https://github.com/apache/zeppelin/blob/f43d27f0bd9f841d71450ae303dc6f9f671bae0a/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js#L1123
    
      newPara.dateFinished !== oldPara.dateFinished || 
    ```
    
    But `newPara.text !== oldPara.text ||` is ok it's more accurate condition 
on if stmt. 
    
    
![1492-cant-reproduce](https://cloud.githubusercontent.com/assets/4968473/24195725/43794b80-0f3e-11e7-871f-a88ad51cc82d.gif)
    
    ### I can't reproduce focus issue too
    
    in 1492, @FRosner said that 
    
    > 1. Enter code in a cell
    > 2. Remove the focus to rename the notebook
    > 3. The code gets reset
    
    But I can't reproduce in current master.
    
    
![1492-focus](https://cloud.githubusercontent.com/assets/4968473/24196075/9e710a5e-0f3f-11e7-9343-58165e2cd63e.gif)
    
    ### Save paragraphs automatically when focus is lost.
    
    So this is more about **save paragraph when focus is lost** instead of 
resolving the problem submitted in 1492.
    
    ```js
    $scope.editor.on('blur', function() {
              handleFocus(false);                         handleFocus(false);
     +        $scope.saveParagraph($scope.paragraph);
            });                 });
    ```
    
    In current implementation Zeppelin will save when user refresh browsers. 
But this PR will cause more frequent `paragraph.text` overwriting.  
    I don't have strong opinion about the behavior, so I would like to other 
people's opinions. 
    
    @Leemoonsoo @AhyoungRyu What do you think of? 
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---