[GitHub] zeppelin pull request #2374: [ZEPPELIN-2593] Add storage settings to persist...

[khalidhuseynov]

GitHub user khalidhuseynov reopened a pull request:

    https://github.com/apache/zeppelin/pull/2374

    [ZEPPELIN-2593] Add storage settings to persist on commit

    ### What is this PR for?
    adding settings to storage layer to let user choose to persist continuously 
or only on commits
    
    
    ### What type of PR is it?
    Improvement | Feature
    
    ### Todos
    * [x] - add notebook repo setting
    * [x] - add save & commit 
    * [x] - add tests
    
    ### What is the Jira issue?
    [ZEPPELIN-2593](https://issues.apache.org/jira/browse/ZEPPELIN-2593)
    
    ### How should this be tested?
    1. go to notebook repo menu and click on edit `Global settings`
    2. change value of `Note persistence` item to `Persist on note commits`
    3. go change any note, although it will be changed in memory, it won't be 
persisted
    4. to check above can reload notes in note list view -> will see original 
note
    5. can save note by `Save & Commit` in version control menu of note
    
    ### Screenshots (if appropriate)
    notebook repo menu
    <img width="1076" alt="screen shot 2017-06-12 at 5 57 12 pm" 
src="https://user-images.githubusercontent.com/1642088/27026300-41860ea4-4f98-11e7-8e5a-a36cb64b98fc.png";>
    
    
    version control menu
    <img width="923" alt="screen shot 2017-06-12 at 5 55 04 pm" 
src="https://user-images.githubusercontent.com/1642088/27026217-fb43c152-4f97-11e7-86f1-627dea1fe3ce.png";>
    
    
    ## Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/khalidhuseynov/zeppelin feat/ZEPPELIN-2593

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2374.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2374
    
----
commit 2fb70ae2c365f5a02e8da182324db6847e4f5dfa
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-05-29T07:48:06Z

    initial flow

commit 0a007f55d73e24ad9610861399b44c0a83dede09
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-09T07:14:07Z

    add temp test

commit 43d6cf6d18a4d4c5cdd58096e476a27f6a0d9e33
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-09T10:39:02Z

    rework settings into global

commit 7b7bedcdf8fd21bed4f617550c0197b49d7e3843
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-12T05:16:10Z

    change checkpoint signature with recent note

commit 4d93f482808719b8768c2ae5c1579d8921530ae0
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-12T05:16:55Z

    improve test

commit 5d7573dd6baa0e35bbb17eca569e8da7910ab713
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-12T06:42:01Z

    add large test for global setting change

commit e8aeb9660e869c5a0a791344086ea861ceb3c0d6
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-12T08:52:02Z

    add save & commit from note action bar

commit 0c035582964df6d85091635a39f208452e663edd
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-12T12:31:32Z

    fix test, set property back

commit 6ab4b597834b3e376f59e034f7ce1c967de3596c
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-12T13:34:01Z

    move setting from global to per repo and apply to remote s3 and zh

commit 5681d49055da94a527e39efc5faa910a53aa2b19
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-26T18:22:20Z

    add conditional save in s3

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---