Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2374
  
    What is the current persistent policy ? Does it persist on every run ? 
    
    And the property name `zeppelin.notebook.persist.on.commit` is a little 
confusing to me. 
    * If it is set to false, does it mean it would not persist when user click 
the saveAndCommit button ? 
    * From the Database perspective (since commit is a concept from database), 
commit should mean persisting. If commit doesn't mean persisting, this might 
confuse users. 
    * So I would suggest to use `zeppelin.notebook.persist.on.run` which mean 
doing persisting on each run.
    * BTW, we should also add doc to mention what is the purpose of this 
property. I guess it is for performance, but with the risk of losing data.
    
    What do you think ?
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to