GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/2497
[ZEPPELIN-2779] Unit test for job module (zeppelin-web)
### What is this PR for?
Added few test cases for the `job` module under `zeppelin-web/`
Additionally,
- removed lodash, q dependency
- converted to `JobModule`
- refactored `jobmanager/*`
### What type of PR is it?
[Improvement]
### What is the Jira issue?
[ZEPPELIN-2779](https://issues.apache.org/jira/browse/ZEPPELIN-2779)
### How should this be tested?
1. cd `zeppelin-web`
2. `yarn install` (or `npm install`)
3. `yarn run test` (or `npm run test`)
The test should pass.
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin
ZEPPELIN-2779/add-unit-test-for-job-page
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2497.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2497
----
commit 2349865e7dc2e63ebe13152670c0d9de1e1f7695
Author: 1ambda <[email protected]>
Date: 2017-07-17T12:36:32Z
refactor: Use ng-bind, remove useless ng-if
commit 0c30422cd9fe5c5742441b8e4b47c97bea011ea7
Author: 1ambda <[email protected]>
Date: 2017-07-17T12:50:41Z
fix: Remove job-control.html
commit 2439f7ed8eb59b523c4dab25dd06c1ecafd6ab01
Author: 1ambda <[email protected]>
Date: 2017-07-17T14:00:09Z
fix: Refactor job-progress-bar
commit ca16c997d01c322385ca81cf119eb23a633e356e
Author: 1ambda <[email protected]>
Date: 2017-07-17T14:01:24Z
fix: Remove job-progress-bar.html
commit dee5e66d0f22266e320dbee2b4b5e282c89695d3
Author: 1ambda <[email protected]>
Date: 2017-07-17T14:02:24Z
fix: Remove job-status
commit 687970099625288f133a2db773c47a54023cf190
Author: 1ambda <[email protected]>
Date: 2017-07-17T14:13:59Z
refactor: job.html
commit 504ab1145ef12634ed79f63ff61fbb49cf31c094
Author: 1ambda <[email protected]>
Date: 2017-07-17T14:27:10Z
refactor: job.controller.js
commit f7c769cbab1a856b00e6f6edc98247ffc536b90b
Author: 1ambda <[email protected]>
Date: 2017-07-17T14:44:53Z
fix: Remove lodash dep in job.controller.js
commit 379394ad6d9ab3d6fdc2f47d097841d31bed817e
Author: 1ambda <[email protected]>
Date: 2017-07-17T14:47:19Z
fix: Use the word 'Paragraph' instead of 'Job'
commit 3762abe80229ef5b30465801834c0fa353894e58
Author: 1ambda <[email protected]>
Date: 2017-07-17T15:41:09Z
refactor: rename jobs to job
commit 5ba277242ca3c3701b37adcd81cbd24635f4d1ac
Author: 1ambda <[email protected]>
Date: 2017-07-18T02:07:18Z
fix: Create job.component.js
commit 3dcf5da9b27028ede267c4f1d733f88a0ebd08cc
Author: 1ambda <[email protected]>
Date: 2017-07-18T18:23:51Z
test: Add job.component.test.js
commit bc6e24fa156b9b20cdb4a50c5af5808072d6b429
Author: 1ambda <[email protected]>
Date: 2017-07-18T18:30:37Z
fix: Use a seperate HTML file for job
commit e88600d944eef8cf73e94d7d6dfbcb54cb51913e
Author: 1ambda <[email protected]>
Date: 2017-07-18T18:32:50Z
fix: lint errors in /job
commit 2af5c2db52dac1c2c35ef07323fed448dfae191c
Author: 1ambda <[email protected]>
Date: 2017-07-19T06:44:13Z
fix: Remove lodash dependency in jobmanager
commit 6176e59dd38502dc3349b83ca3d8e0bb5e0aeea2
Author: 1ambda <[email protected]>
Date: 2017-07-19T07:14:23Z
refactor: Rename variables
commit f1f4c6d35ab6bf814794bf321d7cec25af13f5e4
Author: 1ambda <[email protected]>
Date: 2017-07-19T07:17:47Z
refactor: Define job releated filter in jobmanager.js
commit 954943dadb535d8d4bf3070f70b47d8c3eeebd07
Author: 1ambda <[email protected]>
Date: 2017-07-19T07:18:46Z
fix: Remove unused var
commit 7f088c17f0392fe602a83aef4731c3495a8d0c45
Author: 1ambda <[email protected]>
Date: 2017-07-19T08:02:56Z
refactor: Remove ng-init
commit f3431860127c571a5d2947fe5118f6700404fddc
Author: 1ambda <[email protected]>
Date: 2017-07-19T19:35:07Z
test: job.component.test.js
commit 41e76c695651e1ba6d52d74415889da53b315099
Author: 1ambda <[email protected]>
Date: 2017-07-19T19:38:23Z
fix: Remove q dependency
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
