GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/2497
[ZEPPELIN-2779] Unit test for job module (zeppelin-web) ### What is this PR for? Added few test cases for the `job` module under `zeppelin-web/` Additionally, - removed lodash, q dependency - converted to `JobModule` - refactored `jobmanager/*` ### What type of PR is it? [Improvement] ### What is the Jira issue? [ZEPPELIN-2779](https://issues.apache.org/jira/browse/ZEPPELIN-2779) ### How should this be tested? 1. cd `zeppelin-web` 2. `yarn install` (or `npm install`) 3. `yarn run test` (or `npm run test`) The test should pass. ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2779/add-unit-test-for-job-page Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2497.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2497 ---- commit eae50011f1d3296f952d4dadb85ada8b2e9baa0b Author: 1ambda <1am...@gmail.com> Date: 2017-07-17T12:36:32Z refactor: Use ng-bind, remove useless ng-if commit 2b908938fbedf38ff220eeb4b772000900756234 Author: 1ambda <1am...@gmail.com> Date: 2017-07-17T12:50:41Z fix: Remove job-control.html commit 3b21fc83f7631f1824eba30493efdad5c290e7d9 Author: 1ambda <1am...@gmail.com> Date: 2017-07-17T14:00:09Z fix: Refactor job-progress-bar commit 959d91c33b25554dd6171c472ae0fbc4f32a2d78 Author: 1ambda <1am...@gmail.com> Date: 2017-07-17T14:01:24Z fix: Remove job-progress-bar.html commit 99420f860e0d5d149d0e23ce606e748713e1fc8d Author: 1ambda <1am...@gmail.com> Date: 2017-07-17T14:02:24Z fix: Remove job-status commit 52634bd00ebe5196642b4085f9124d164b77149c Author: 1ambda <1am...@gmail.com> Date: 2017-07-17T14:13:59Z refactor: job.html commit b34a3762ee793fd9458b0862ee9338a96e46b0b6 Author: 1ambda <1am...@gmail.com> Date: 2017-07-17T14:27:10Z refactor: job.controller.js commit 3ed244607471efebd3d694cd66c284aa58a187b6 Author: 1ambda <1am...@gmail.com> Date: 2017-07-17T14:44:53Z fix: Remove lodash dep in job.controller.js commit dd4598b6f26276dc2a64b7fe6594ed202698e313 Author: 1ambda <1am...@gmail.com> Date: 2017-07-17T14:47:19Z fix: Use the word 'Paragraph' instead of 'Job' commit e0b102d3c740989904b2e3fa54075eeb68cd7dd8 Author: 1ambda <1am...@gmail.com> Date: 2017-07-17T15:41:09Z refactor: rename jobs to job commit 6d8b1a7023f606cf92c68a47e5824efc0645731b Author: 1ambda <1am...@gmail.com> Date: 2017-07-18T02:07:18Z fix: Create job.component.js commit bb334e087ea75903186ef36ef30aa65209af52fc Author: 1ambda <1am...@gmail.com> Date: 2017-07-18T18:23:51Z test: Add job.component.test.js commit cc452b982c7db30a3112c7ecd7b95a366de859b8 Author: 1ambda <1am...@gmail.com> Date: 2017-07-18T18:30:37Z fix: Use a seperate HTML file for job commit 22b15a8da53ad7395715658f969f96fb1b843d9c Author: 1ambda <1am...@gmail.com> Date: 2017-07-18T18:32:50Z fix: lint errors in /job commit a6618b8fe5f31224a0b90651ac648f44995d44dd Author: 1ambda <1am...@gmail.com> Date: 2017-07-19T06:44:13Z fix: Remove lodash dependency in jobmanager commit 6074c6c6cd063ee6ae7ee0d23d0b930d57b98964 Author: 1ambda <1am...@gmail.com> Date: 2017-07-19T07:14:23Z refactor: Rename variables commit 609c42c5d023c5f3302ed39f14cbb3e9b304882c Author: 1ambda <1am...@gmail.com> Date: 2017-07-19T07:17:47Z refactor: Define job releated filter in jobmanager.js commit 40b6cf721a2adedfcc2347743206dc104f1c5c79 Author: 1ambda <1am...@gmail.com> Date: 2017-07-19T07:18:46Z fix: Remove unused var commit dce4450913ffb6d120e3c1e77d451b6f874eb3bb Author: 1ambda <1am...@gmail.com> Date: 2017-07-19T08:02:56Z refactor: Remove ng-init commit c58c6ddb2356ecc26303ed84164955bde0c7fa77 Author: 1ambda <1am...@gmail.com> Date: 2017-07-19T19:35:07Z test: job.component.test.js commit d264a52aaf6cbf20de8dbd7bfbe4478c0d1a7033 Author: 1ambda <1am...@gmail.com> Date: 2017-07-19T19:38:23Z fix: Remove q dependency commit 929b00c641606178dbd5a3847567d818e474fc61 Author: 1ambda <1am...@gmail.com> Date: 2017-07-20T02:49:56Z fix: DON'T import job.css in index.html commit 2c0bd0e651ef0e02a815a9488865f794c937f23c Author: 1ambda <1am...@gmail.com> Date: 2017-07-21T08:35:46Z fix: Add comments commit 8c2d32fa760c4216fbee5f6e5f6257f71c869035 Author: 1ambda <1am...@gmail.com> Date: 2017-07-21T08:37:07Z fix: Removed the duplicated test commit 2bea70a33191e2d82ceefaa4c21b7084334d46de Author: 1ambda <1am...@gmail.com> Date: 2017-07-21T09:04:39Z refactor: Move http related actions into srv commit 578aa9fb006b791b03e6b08f4b70b98c555bf28c Author: 1ambda <1am...@gmail.com> Date: 2017-07-21T15:46:34Z fix: DO NOT display loading spin always commit 2e12c21197d916b864e3c29c627d929992ee89a2 Author: 1ambda <1am...@gmail.com> Date: 2017-07-21T16:10:46Z refactor: Move to service commit ae3b79a4326221a1ecb714ec8ae063ae1a0890d3 Author: 1ambda <1am...@gmail.com> Date: 2017-07-21T16:22:37Z fix: Use uppercase for filter commit 232c406a3d7445890440705a71924a8959a8b812 Author: 1ambda <1am...@gmail.com> Date: 2017-07-21T16:37:29Z test: Add jobmanager.service.test commit 0c410c5c14b1c5f7fa21916487203d5107c63b89 Author: 1ambda <1am...@gmail.com> Date: 2017-07-21T16:49:45Z fix: lint error ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---