GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/2757
[ZEPPELIN-3198] UI should not show Version/GIT Control if the same if not
supported
### What is this PR for?
Currently, UI shows an option for version/GIT Control even when it is not
supported by the underlying implementing storage configuration.
It is only after users try to save a commit and get an error "Couldn't
checkpoint note revision: possibly storage doesn't support versioning. Please
check the logs for more details.".
So, if implementing storage configuration doesn't support git storage, UI
should not show those options.
### What type of PR is it?
[Improvement]
### What is the Jira issue?
*
[ZEPPELIN-3198](https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-3198)
### How should this be tested?
On using "org.apache.zeppelin.notebook.repo.GitNotebookRepo" for
`zeppelin.notebook.storage` user should see revision/version control option,
for rest of the others e.g. "FileSystemNotebookRepo" user should not see that
option
### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3198
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2757.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2757
----
commit cd7fde105c5017ac5ef8fab956c79987529fc10d
Author: Prabhjyot Singh <prabhjyotsingh@...>
Date: 2018-02-01T09:38:50Z
ZEPPELIN-3198: add isRevisionSupported for NotebookRepo
Change-Id: I67af210fb003e007129db4b24e5f8f53fb034c6f
----
---
