Github user jhonderson commented on the issue:

    https://github.com/apache/zeppelin/pull/2757
  
    The methods for the versioning of the notes are defined at interface level 
in NotebookRepo.java:
    
     - Revision checkpoint(String noteId, String checkpointMsg, 
AuthenticationInfo)
     - Note get(String noteId, String revId, AuthenticationInfo)
     - List<Revision> revisionHistory(String noteId, AuthenticationInfo)
     - Note setNoteRevision(String noteId, String revId, AuthenticationInfo)
    
    They could be implemented by a non-git repository, for example a repository 
that saves the notes in S3 and its versioning information in a database or 
something like that. So i guess a better solution would be a method in 
NotebookRepo.java that indicates if the implementation supports versioning 
(maybe doesSupportVersioning()); and use that method to show or hide the 
versioning feature.
    
    What do you think?.


---

Reply via email to