Maxim Belousov created ZEPPELIN-3344:
----------------------------------------
Summary: Revert comments in JDBC interpreter
Key: ZEPPELIN-3344
URL: https://issues.apache.org/jira/browse/ZEPPELIN-3344
Project: Zeppelin
Issue Type: Bug
Affects Versions: 0.8.0, 0.9.0
Reporter: Maxim Belousov
Assignee: Maxim Belousov
In Zeppelin the paragraph can contain multiple SQL queries delimeted by ';'.
The original purpose of PR251 [1] was correct processing of ';'. This was done
via full removing comments from code.
Unfortunately Apache Phoenix uses hooks in comments [2].
Thus we should not delete comments in scripts.
There was discussion about comment rules for different databases (solr). The
right way is keep style. Thus analysts can copy queries to another tool and can
get same results and errors.
[1]. https://github.com/apache/zeppelin/pull/2158 [ZEPPELIN-2279] excluded
comments from SQL
[2]. https://forcedotcom.github.io/phoenix/#hint
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
