GitHub user mebelousov opened a pull request:
https://github.com/apache/zeppelin/pull/2876
ZEPPELIN-3344. Revert comments in queries in JDBC interpreter
### What is this PR for?
The original purpose of https://github.com/apache/zeppelin/pull/2158 was
correct processing of ';'. This was done via full removing comments from code.
Unfortunately Apache Phoenix uses hooks in comments
https://forcedotcom.github.io/phoenix/#hintml.
Thus we should not delete comments in scripts.
There was discussion about comment rules for different databases (solr).
The right way is keep style. Thus analysts can copy queries to another tool and
can get same results and errors.
### What type of PR is it?
[Bug Fix]
### What is the Jira issue?
* [ZEPPELIN-3344]
### How should this be tested?
* Unit tests pass: testSplitSqlQueryWithComments and testSplitSqlQuery
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-3344
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2876.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2876
----
commit eed54c89216e4e07e4c82b82f6a740928969205d
Author: mebelousov <mebelousov@...>
Date: 2018-03-16T13:26:06Z
ZEPPELIN-3344 Revert comments in JDBC interpreter
commit 83c8e8faa5ba6b0e46ed51d530b2b3bae362d036
Author: mebelousov <mebelousov@...>
Date: 2018-03-16T13:34:42Z
ZEPPELIN-3344 Rename test
----
---
