Reamer commented on a change in pull request #4059:
URL: https://github.com/apache/zeppelin/pull/4059#discussion_r580088979
##########
File path:
zeppelin-server/src/main/java/org/apache/zeppelin/service/ShiroAuthenticationService.java
##########
@@ -247,6 +248,9 @@ public boolean isAuthenticated() {
} else if (ACTIVE_DIRECTORY_GROUP_REALM.equals(name)) {
allRoles = ((ActiveDirectoryGroupRealm) realm).getListRoles();
break;
+ } else if (realm instanceof KnoxJwtRealm) {
Review comment:
You have an advantage when you do a string comparison.
There is a fixed string in the configuration and you can change the
underlying implementation independently of the configuration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
