Kimahriman commented on a change in pull request #4059:
URL: https://github.com/apache/zeppelin/pull/4059#discussion_r580175872
##########
File path:
zeppelin-server/src/main/java/org/apache/zeppelin/service/ShiroAuthenticationService.java
##########
@@ -247,6 +248,9 @@ public boolean isAuthenticated() {
} else if (ACTIVE_DIRECTORY_GROUP_REALM.equals(name)) {
allRoles = ((ActiveDirectoryGroupRealm) realm).getListRoles();
break;
+ } else if (realm instanceof KnoxJwtRealm) {
Review comment:
I don't really follow. We have to cast it to get the class specific
behavior, so we're kinda relying on the implementation. And it prevents
subclassing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
