jongyoul commented on code in PR #4419:
URL: https://github.com/apache/zeppelin/pull/4419#discussion_r927495792
##########
zeppelin-interpreter/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java:
##########
@@ -636,8 +633,12 @@ public String getInterpreterPortRange() {
return getString(ConfVars.ZEPPELIN_INTERPRETER_RPC_PORTRANGE);
}
- public boolean isWindowsPath(String path){
- return path.matches("^[A-Za-z]:\\\\.*");
+ public boolean isWindowsCheck(){
+ Boolean wc = SystemUtils.IS_OS_WINDOWS;
+ if(Objects.isNull(wc)) {
Review Comment:
It returns a primitive type. I guess you don't have to check if it's null or
not.
https://commons.apache.org/proper/commons-lang/javadocs/api-release/org/apache/commons/lang3/SystemUtils.html#IS_OS_WINDOWS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
