jongyoul commented on code in PR #4419:
URL: https://github.com/apache/zeppelin/pull/4419#discussion_r927577081
##########
zeppelin-zengine/src/test/java/org/apache/zeppelin/conf/ZeppelinConfigurationTest.java:
##########
@@ -69,18 +69,18 @@ public void getAllowedOriginsNoneTest() throws
MalformedURLException {
}
@Test
- public void isWindowsPathTestTrue() {
+ public void checkWindowsTestTrue() {
ZeppelinConfiguration conf =
ZeppelinConfiguration.create("zeppelin-test-site.xml");
- Boolean isIt = conf.isWindowsPath("c:\\test\\file.txt");
+ Boolean isIt = conf.checkWindows();
Assert.assertTrue(isIt);
}
@Test
- public void isWindowsPathTestFalse() {
+ public void checkWindowsTestFalse() {
ZeppelinConfiguration conf =
ZeppelinConfiguration.create("zeppelin-test-site.xml");
- Boolean isIt = conf.isWindowsPath("~/test/file.xml");
+ Boolean isIt = conf.checkWindows();
Assert.assertFalse(isIt);
}
Review Comment:
How do the tests work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
