[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4556: [ZEPPELIN-5875] Fix flaky tests in `core-modules`

[GitBox]

jongyoul commented on code in PR #4556:
URL: https://github.com/apache/zeppelin/pull/4556#discussion_r1070564606


##########
zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/PooledRemoteClient.java:
##########
@@ -44,6 +45,7 @@ public PooledRemoteClient(SupplierWithIO<T> supplier, int 
connectionPoolSize) {
     GenericObjectPoolConfig poolConfig = new GenericObjectPoolConfig();
     poolConfig.setMaxTotal(connectionPoolSize);
     poolConfig.setMaxIdle(connectionPoolSize);
+    
poolConfig.setEvictionPolicyClassName(DefaultEvictionPolicy.class.getName());

Review Comment:
   It's similar to the above case. We can add ignore rule for shade as well but 
I think it's better to set up the class name explicitly
   
   ```
   Error: Exception in thread "main" java.lang.IllegalArgumentException: Unable 
to create EvictionPolicy instance of type 
org/apache/zeppelin/shaded/org.apache.zeppelin.shaded.org.apache.commons.pool2.impl.DefaultEvictionPolicy
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org