[GitHub] [zeppelin] Reamer commented on a diff in pull request #4556: [ZEPPELIN-5875] Fix flaky tests in `core-modules`

[GitBox]

Reamer commented on code in PR #4556:
URL: https://github.com/apache/zeppelin/pull/4556#discussion_r1070943224


##########
.github/workflows/core.yml:
##########
@@ -59,7 +59,8 @@ jobs:
             !~/.m2/repository/org/apache/zeppelin/
             ~/.spark-dist
             ~/.cache
-          key: ${{ runner.os }}-zeppelin-${{ hashFiles('**/pom.xml') }}
+            ~/conda_pkgs_dir
+          key: ${{ runner.os }}-zeppelin-${{ hashFiles('**/pom.xml') }}-${{ 
hashFiles('testing/env_python_3.7_with_R.yml') }}

Review Comment:
   Why `${{ hashFiles('testing/env_python_3.7_with_R.yml') }}`? We do not have 
a conda environment in the CI cache.



##########
zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/PooledRemoteClient.java:
##########
@@ -44,6 +45,9 @@ public PooledRemoteClient(SupplierWithIO<T> supplier, int 
connectionPoolSize) {
     GenericObjectPoolConfig poolConfig = new GenericObjectPoolConfig();
     poolConfig.setMaxTotal(connectionPoolSize);
     poolConfig.setMaxIdle(connectionPoolSize);
+    // ZEPPELIN-5875 maven-shade-plugin issue
+    // 
`org/apache/zeppelin/shaded/org.apache.zeppelin.shaded.org.apache.commons.pool2.impl.DefaultEvictionPolicy`

Review Comment:
   I think we still have a shade problem.
   
`org/apache/zeppelin/shaded/org.apache.zeppelin.shaded.org.apache.commons.pool2.impl.DefaultEvictionPolicy`
 does not look like a good class name. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org