[ 
https://issues.apache.org/jira/browse/ZEPPELIN-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392673#comment-14392673
 ] 

ASF GitHub Bot commented on ZEPPELIN-19:
----------------------------------------

Github user Leemoonsoo commented on a diff in the pull request:

    https://github.com/apache/incubator-zeppelin/pull/22#discussion_r27654371
  
    --- Diff: 
zeppelin-interpreter/src/main/java/com/nflabs/zeppelin/scheduler/Job.java ---
    @@ -237,4 +238,8 @@ public Date getDateFinished() {
       private Logger logger() {
         return LoggerFactory.getLogger(Job.class);
       }
    +
    +  protected void setResult(InterpreterResult result) {
    --- End diff --
    
    Could you make setResult(Object result) instead of 
setResult(InterpreterResult result)?
    Because of Job is designed to allow any java object as a result.


> Failures from disabled interpreters not reported
> ------------------------------------------------
>
>                 Key: ZEPPELIN-19
>                 URL: https://issues.apache.org/jira/browse/ZEPPELIN-19
>             Project: Zeppelin
>          Issue Type: Bug
>            Reporter: Ram Venkatesh
>
> On a note, if an interpreter is disabled for any reason, errors from 
> paragraph execution not surfaced to the user. This can also happen on 
> interpreter startup failures.
> The logs do have an NPE in them, but it would be good to give the user some 
> feedback on the failure.
> Pull request to follow shortly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to