[ 
https://issues.apache.org/jira/browse/ZEPPELIN-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393974#comment-14393974
 ] 

ASF GitHub Bot commented on ZEPPELIN-19:
----------------------------------------

Github user RamVenkatesh commented on a diff in the pull request:

    https://github.com/apache/incubator-zeppelin/pull/22#discussion_r27712863
  
    --- Diff: 
zeppelin-zengine/src/main/java/com/nflabs/zeppelin/notebook/Note.java ---
    @@ -231,6 +232,9 @@ public void run(String paragraphId) {
         p.setNoteReplLoader(replLoader);
         p.setListener(jobListenerFactory.getParagraphJobListener(this));
         Interpreter intp = replLoader.get(p.getRequiredReplName());
    +    if (intp == null) {
    --- End diff --
    
    @Leemoonsoo  thank you for the review.
    
    I have made the following changes:
    1. for NPEs getMessage() is null, hence no error is shown on the GUI. I 
have fixed this in InterpreterUtils.getMostRelevantMessage
    2. added a test for this specific case to throw an InterpreterException 
instead of NPE
    



> Failures from disabled interpreters not reported
> ------------------------------------------------
>
>                 Key: ZEPPELIN-19
>                 URL: https://issues.apache.org/jira/browse/ZEPPELIN-19
>             Project: Zeppelin
>          Issue Type: Bug
>            Reporter: Ram Venkatesh
>
> On a note, if an interpreter is disabled for any reason, errors from 
> paragraph execution not surfaced to the user. This can also happen on 
> interpreter startup failures.
> The logs do have an NPE in them, but it would be good to give the user some 
> feedback on the failure.
> Pull request to follow shortly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to