GitHub user khalidhuseynov opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/634

    fix logging to informative one

    ### What is this PR for?
    Improving logging information on error
    
    ### What type of PR is it?
    Fix/Improvement
    
    ### Todos
    * [x] - fix logging 
    
    ### Is there a relevant Jira issue?
    May not require issue
    
    ### How should this be tested?
    Can be tested with any error for storage initialization
    For example:
    1. in `conf/zeppelin-env.sh` add the following line
        ```
        export 
ZEPPELIN_NOTEBOOK_STORAGE="org.apache.zeppelin.notebook.repo.VFSNotebookRepo,org.apache.zeppelin.notebook.repo.DummyNotebookRepo"
        ```
    2. Start Zeppelin
    3. Previously you would see one line warning, now you would see more 
detailed trace-back as well.
    
    ### Screenshots (if appropriate)
    Before: 
    ```
    Failed to initialize com.nflabs.zeppelinhub.notebook.repo.DummyNotebookRepo 
notebook storage class java.lang.reflect.InvocationTargetException
    ```
    After:
    ```
    WARN [2016-01-13 22:43:05,557] ({main} NotebookRepoSync.java[<init>]:81) - 
Failed to initialize com.nflabs.zeppelinhub.notebook.repo.DummyNotebookRepo 
notebook storage class
    java.lang.reflect.InvocationTargetException
        at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
        at 
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
        at 
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
    ```
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/khalidhuseynov/incubator-zeppelin fix-logging

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/634.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #634
    
----
commit dd655551e7573a05d912d46b853031507d2df2d7
Author: Khalid Huseynov <khalid...@nflabs.com>
Date:   2016-01-13T13:52:06Z

    fix logging to informative one

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to