Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/413#issuecomment-188511648
@fireboy1919 thank you for contribution!
The approach you take looks interesting, please help me to understand how
much would that affect other existing notebook storages\interpreters
implementations?
As review takes some time and effort, there are few things you can do to
seed things us, by simplifying life of the reviewer *a lot* (in order of
simplicity)
- [ ] us the [template for PR
description](https://github.com/apache/incubator-zeppelin/blob/master/CONTRIBUTING.md#creating-a-pull-request)
from the docs
- [ ] minimize the re-formatting changes like
[this](https://github.com/apache/incubator-zeppelin/pull/413/files#diff-199a5155679a305a544902edda0c6fb7R48)
or
[this](https://github.com/apache/incubator-zeppelin/pull/413/files#diff-199a5155679a305a544902edda0c6fb7L231),
etc, as it makes hard to distinguish important changes
- [ ] make sure that [ALL your
code](https://github.com/apache/incubator-zeppelin/pull/413/files#diff-e6203ed80e3d3f3552efea7b79484ff4R42)
style is consistent with the project's [style guide's code
conventions](https://github.com/apache/incubator-zeppelin/blob/master/CONTRIBUTING.md#code-convention)
and the other code that you have changed. This looks like a nit, but it speeds
the process up, removing the need to scatter reviewers attention between
important changes and just minor style one's
- [ ] keep your branch rebased on latest master
- [ ] make sure the CI is green
- [ ] ping somebody (using Gihutb mentions in this PR) as soon as you feel
that it is ready for a review\merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
