Github user granturing commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/734#issuecomment-192776037
Couple questions:
* The Shell interpreter uses bash, which obviously won't work on Windows.
I've confirmed the interpreter will work with a couple changes to support the
Windows CMD shell. I can either set a value to decide which interpreter to use
at runtime, based on the OS, or we make it configurable. Is it worth making it
configurable?
```Java
private static final boolean isWindows = System.getProperty("os.name")
.startsWith("Windows");
private final String shell = isWindows ? "cmd /c" : "bash -c";
```
* Units tests in the zeppelin-interpreter project have a reference to
"../bin/interpreter.sh", which of course won't work on Windows. I've verified
the unit tests using "../bin/interpreter.cmd". I just didn't like the fact that
when I'm in Windows I can't run all the unit tests. I can either have a static
variable which defines what script to use in each unit test or I add a helper
class to centralize it and all unit tests reference that. What would you prefer?
```Java
private static final String INTERPRETER_SCRIPT =
System.getProperty("os.name").startsWith("Windows") ?
"../bin/interpreter.cmd" :
"../bin/interpreter.sh";
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
