GitHub user granturing reopened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/734

    [ZEPPELIN-647] - Native Windows support for startup scripts and 
configuration

    ### What is this PR for?
    This is to give Windows first-class support for running Zeppelin without 
the need for Cygwin or other hacks.
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    * [x] - Fix notebook dir path handling which right now assumes URI 
compatible string (see 
https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/VFSNotebookRepo.java#L63)
    * [x] - Add documentation for configuring and running on Windows
    * [x] - Independent code review of the CMD scripts to ensure they're correct
    
    ### Is there a relevant Jira issue?
    ZEPPELIN-647
    
    ### How should this be tested?
    * Pull this PR
    * Build
    * Override default ZEPPELIN_NOTEBOOK_DIR in zeppelin-env.cmd to be an 
absolute file URI such as file:///c:/notebook
    * Start with bin\zeppelin.cmd
    * If using any Hadoop system ensure you have winutils.exe in your 
HADOOP_HOME\bin, see (https://github.com/steveloughran/winutils)
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? Yes

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/granturing/incubator-zeppelin windows-support

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/734.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #734
    
----
commit 9e404823cf4c56a948cd49fb896c1de6775a70c1
Author: Silvio Fiorito <silvio fiorito>
Date:   2016-02-15T13:54:07Z

    Initial support for Windows platform, startup scripts

commit 5b49d3ebf9a8135cf00da3f5d9d1ea385fbc5618
Author: Silvio Fiorito <silvio fiorito>
Date:   2016-02-21T01:28:21Z

    Cleaned up indentation

commit d30e4b98196459769c1a5ec4b543c6992b03cbe0
Author: Silvio Fiorito <silvio fiorito>
Date:   2016-02-21T01:31:28Z

    And again fix indentations missed last time

commit c700808b783bbfcc2fc24017a9316aa1d6dd7951
Author: Silvio Fiorito <silvio.fior...@granturing.com>
Date:   2016-03-02T00:43:56Z

    Check for Windows path before creating URI to prevent URISyntaxExecption

commit 2b9f01c8ff2ab5c353a5874e941336ea3789a14c
Author: Silvio Fiorito <silvio.fior...@granturing.com>
Date:   2016-03-03T01:55:17Z

    Fix for pyspark PYTHONPATH environment variable not being set properly due 
to delayed expansion

commit 03baf62b44d1a691342372f45920c59d97662220
Author: Silvio Fiorito <silvio.fior...@granturing.com>
Date:   2016-03-03T06:07:35Z

    Additional fix for embedded pyspark environment variables

commit 9e8b3094b53736d371b6a5582f2f8c5ba73b4057
Author: Silvio Fiorito <silvio.fior...@granturing.com>
Date:   2016-03-03T06:09:10Z

    Initital doc updates for running on Windows

commit 82acdcf4eb0f8256cf3cdac0c2586c3330c548fc
Author: Silvio Fiorito <silvio.fior...@granturing.com>
Date:   2016-03-03T06:54:42Z

    Merge branch 'master' into windows-support
    
    resolved conflict in docs/install/install.md

commit a1e30973c2fe38eecad59d33cdbd544a1979a40f
Author: Silvio Fiorito <silvio.fior...@granturing.com>
Date:   2016-03-10T05:04:08Z

    Support for Windows CMD shell interpreter

commit db28fe92702321489066add2459658810ccd8235
Author: Silvio Fiorito <silvio.fior...@granturing.com>
Date:   2016-03-10T05:07:16Z

    Support for running unit tests on Windows using the appropriate interpreter 
script

commit 73aaf4f7d288321c9fae99eeec22b7da1335d91c
Author: Silvio Fiorito <silvio.fior...@granturing.com>
Date:   2016-03-10T05:08:02Z

    Default to the appropriate interpreter when running on Windows

commit 8aadd457629da9f6ee6cce2e40e262e5875b6f00
Author: Silvio Fiorito <silvio.fior...@granturing.com>
Date:   2016-03-15T03:17:32Z

    Fixes to handle spaces in paths properly, both for ZEPPELIN_HOME and 
CLASSPATH

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to