Github user bzz commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/873#issuecomment-217056217
  
    Hi @onkarshedge thank you for submitting a fix!
    
    In case of fixing a bug in any code, first thing to do is to try adding 
some kind of (unit-)test to the existing project test suite in order to 
reproduce the bug. And then implement the fix and make sure the tests pass.
    This way we are building a "safe-net", so other people can be sure that 
this particular bug does not happen again, later on.
    
    Good place to add a test that reproduces this bug would be in 
[ZeppelinConfigurationTest.java](https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-zengine/src/test/java/org/apache/zeppelin/conf/ZeppelinConfigurationTest.java)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to