-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/240/
-----------------------------------------------------------
(Updated 2011-01-07 02:21:38.514056)
Review request for zookeeper and fpj.
Changes
-------
Including description. For some reason my description got dropped from the
earlier request.
Summary (updated)
-------
QuorumCnxManager performed blocking socket IO at a few places. As a result, QCM
on a peer could block forever which would prevent other peers from connecting
to the blocked peer.
If the peer happens to be the leader, then it will block new peers from
becoming a follower.
I have made changes as per ZOOKEEPER-932
This addresses bug ZOOKEEPER-932.
https://issues.apache.org/jira/browse/ZOOKEEPER-932
Diffs
-----
trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java
1040328
trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
1040328
trunk/src/java/test/org/apache/zookeeper/test/CnxManagerTest.java 1040328
Diff: https://reviews.apache.org/r/240/diff
Testing
-------
- ant test-core-java
- systest
- basic hand testing
- rebooted follower/leader several times
Thanks,
Vishal
