----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/240/#review88 -----------------------------------------------------------
trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java <https://reviews.apache.org/r/240/#comment162> Nowadays we're not restricted anymore to short variable names. Just call the variable "workerThreadsCounter" and skip the comment. Most developers know, that Cnt will mean Counter, but it doesn't hurt either to just spend a few characters in plus to make it easier to read like text. It adds to the confusion that there is also a method getThreadCount in this class. So there are two possible ways to write Count. trunk/src/java/test/org/apache/zookeeper/test/CnxManagerTest.java <https://reviews.apache.org/r/240/#comment163> indentation above - Thomas On 2011-01-07 02:21:38, Vishal Kher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/240/ > ----------------------------------------------------------- > > (Updated 2011-01-07 02:21:38) > > > Review request for zookeeper and fpj. > > > Summary > ------- > > QuorumCnxManager performed blocking socket IO at a few places. As a result, > QCM on a peer could block forever which would prevent other peers from > connecting to the blocked peer. > If the peer happens to be the leader, then it will block new peers from > becoming a follower. > > I have made changes as per ZOOKEEPER-932 > > > This addresses bug ZOOKEEPER-932. > https://issues.apache.org/jira/browse/ZOOKEEPER-932 > > > Diffs > ----- > > > trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java > 1040328 > trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java > 1040328 > trunk/src/java/test/org/apache/zookeeper/test/CnxManagerTest.java 1040328 > > Diff: https://reviews.apache.org/r/240/diff > > > Testing > ------- > > - ant test-core-java > - systest > - basic hand testing > - rebooted follower/leader several times > > > Thanks, > > Vishal > >
