Such uses of sleep are just asking for trouble. Take a look at the use of sleep in testSessionMove in the same class for a better way to do this. I had gone through all the tests a while back, replacing all the "sleep(x)" with something like this testSessionMove pattern (retry with a max limit that's very long). During reviews we should look for anti-patterns like this and address them before commit.
Patrick On Tue, Jun 21, 2011 at 12:38 PM, Fournier, Camille F. <[email protected]> wrote: > I see that this has failed a few precommit builds now, and someone reported > it failing in their local env regularly. Do we think this is just a general > transient test, or was there a change checked in recently that might related > to this code and its new transient failures? Perhaps it is just the > Thread.sleep(1000) needs to be bumped up. > > C >
