[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051466#comment-13051466
 ] 

Henry Robinson commented on ZOOKEEPER-1097:
-------------------------------------------

You're right, for whatever reason JIRA put your most recent patch second in the 
list of attached files. 

Tabs vs. spaces: thankfully, it's not a matter of opinion (because let's face 
it, what could be more boring...): we have a consistent choice as per 
http://wiki.apache.org/hadoop/ZooKeeper/HowToContribute. I've updated your 
patch with spaces for whitespace. 

We can ignore the inherited problems with those test lines, which are obviously 
just small nits, for now. Given that you were in the code, editing some of 
those lines, seemed like a good opportunity for cleanup. Next time!

I'll commit this shortly. Thanks!

> Quota is not correctly rehydrated on snapshot reload
> ----------------------------------------------------
>
>                 Key: ZOOKEEPER-1097
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1097
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.3.3, 3.4.0
>            Reporter: Camille Fournier
>            Assignee: Camille Fournier
>            Priority: Blocker
>             Fix For: 3.3.4, 3.4.0
>
>         Attachments: 1097.patch, ZOOKEEPER-1097, ZOOKEEPER-1097.patch, 
> ZOOKEEPER-1097.patch
>
>
> traverseNode in DataTree will never actually traverse the limit nodes 
> properly.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to