In QuorumTest, use the same "for ( .. try { break } catch { } )" pattern in testFollowersStartAfterLeaders as in testSessionMove. ---------------------------------------------------------------------------------------------------------------------------------
Key: ZOOKEEPER-1103 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1103 Project: ZooKeeper Issue Type: Improvement Components: tests Affects Versions: 3.4.0 Reporter: Eugene Koontz Assignee: Eugene Koontz Priority: Minor Patrick Hunt writes: "Such uses of sleep [used in testFollowersStartAfterLeader] are just asking for trouble. Take a look at the use of sleep in testSessionMove in the same class for a better way to do this. I had gone through all the tests a while back, replacing all the "sleep(x)" with something like this testSessionMove pattern (retry with a max limit that's very long). During reviews we should look for anti-patterns like this and address them before commit." So, modify testFollowersStartAfterLeaders to use the same retrying approach that testSessionMove uses. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira