[ https://issues.apache.org/jira/browse/ZOOKEEPER-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052869#comment-13052869 ]
Hadoop QA commented on ZOOKEEPER-1103: -------------------------------------- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12483355/ZOOKEEPER-1103.patch against trunk revision 1138100. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/342//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/342//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/342//console This message is automatically generated. > In QuorumTest, use the same "for ( .. try { break } catch { } )" pattern in > testFollowersStartAfterLeaders as in testSessionMove. > --------------------------------------------------------------------------------------------------------------------------------- > > Key: ZOOKEEPER-1103 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1103 > Project: ZooKeeper > Issue Type: Improvement > Components: tests > Affects Versions: 3.3.3, 3.4.0 > Reporter: Eugene Koontz > Assignee: Eugene Koontz > Priority: Minor > Fix For: 3.3.4, 3.4.0 > > Attachments: ZOOKEEPER-1103.patch > > > Patrick Hunt writes: > "Such uses of sleep [used in testFollowersStartAfterLeader] are just asking > for trouble. Take a look at the use > of sleep in testSessionMove in the same class for a better way to do > this. I had gone through all the tests a while back, replacing all the > "sleep(x)" with something like this testSessionMove pattern (retry > with a max limit that's very long). During reviews we should look for > anti-patterns like this and address them before commit." > So, modify testFollowersStartAfterLeaders to use the same retrying approach > that testSessionMove uses. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira