> On 2011-07-07 23:40:32, Patrick Hunt wrote: > > ./src/java/main/org/apache/zookeeper/ZooKeeperPurger.java, lines 74-77 > > <https://reviews.apache.org/r/1043/diff/1/?file=22149#file22149line74> > > > > move this check to the start method. > > > > 1) INFO level log if turned off > > 2) exit the thread if turned off
Sorry, meant exit the start method if turned off (don't start the timer/task). - Patrick ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1043/#review998 ----------------------------------------------------------- On 2011-07-07 23:10:13, Patrick Hunt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1043/ > ----------------------------------------------------------- > > (Updated 2011-07-07 23:10:13) > > > Review request for zookeeper, Patrick Hunt, Benjamin Reed, and Mahadev Konar. > > > Summary > ------- > > I like to have ZK itself manage the amount of snapshots and logs kept, > instead of relying on the PurgeTxnLog utility. > > > This addresses bug ZOOKEEPER-1107. > https://issues.apache.org/jira/browse/ZOOKEEPER-1107 > > > Diffs > ----- > > ./conf/zoo_sample.cfg 1141901 > ./src/java/main/org/apache/zookeeper/ZooKeeperPurger.java PRE-CREATION > ./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java > 1141901 > ./src/java/test/org/apache/zookeeper/ZooKeeperPurgeTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/1043/diff > > > Testing > ------- > > test added, passing hudson qa bot. > > > Thanks, > > Patrick > >
