> On 2011-07-07 23:40:32, Patrick Hunt wrote: > > The documentation (src/docs) need to be updated - specifically the cleanup > > section in the admin guide. > > > > Have you considered hooking this into JMX or the 4letterwords? It would be > > nice for operators to get basic information. In JMX they could also control > > the settings... consider for a follow-on JIRA? > > Laxman Ch wrote: > Fixed the documentation part. > > @Pat: I guess I'm not clear about how "hooking into JMX or 4 > letter-words" will be helpful. Can you please explain this idea? I can takeup > this task in separate JIRA.
both JMX and 4letterwords provide insight to the operator into the runtime status of the system http://zookeeper.apache.org/doc/r3.3.3/zookeeperAdmin.html#sc_zkCommands http://zookeeper.apache.org/doc/r3.3.3/zookeeperJMX.html what I was suggesting is that you could allow such insight into the cleanup task - for example is the process running, when the last time it ran, a history of the files cleaned up and when, stop the task, restart, etc... - Patrick ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1043/#review998 ----------------------------------------------------------- On 2011-07-07 23:10:13, Patrick Hunt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1043/ > ----------------------------------------------------------- > > (Updated 2011-07-07 23:10:13) > > > Review request for zookeeper, Patrick Hunt, Benjamin Reed, and Mahadev Konar. > > > Summary > ------- > > I like to have ZK itself manage the amount of snapshots and logs kept, > instead of relying on the PurgeTxnLog utility. > > > This addresses bug ZOOKEEPER-1107. > https://issues.apache.org/jira/browse/ZOOKEEPER-1107 > > > Diffs > ----- > > ./conf/zoo_sample.cfg 1141901 > ./src/java/main/org/apache/zookeeper/ZooKeeperPurger.java PRE-CREATION > ./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java > 1141901 > ./src/java/test/org/apache/zookeeper/ZooKeeperPurgeTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/1043/diff > > > Testing > ------- > > test added, passing hudson qa bot. > > > Thanks, > > Patrick > >
