[ https://issues.apache.org/jira/browse/ZOOKEEPER-731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097200#comment-13097200 ]
Hadoop QA commented on ZOOKEEPER-731: ------------------------------------- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12493037/ZOOKEEPER-731.patch against trunk revision 1164758. +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/501//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/501//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/501//console This message is automatically generated. > Zookeeper#delete , #create - async versions miss a verb in the javadoc > ------------------------------------------------------------------------ > > Key: ZOOKEEPER-731 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-731 > Project: ZooKeeper > Issue Type: Bug > Components: documentation > Affects Versions: 3.3.0 > Reporter: Kay Kay > Priority: Minor > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-731.patch > > > /** > * The Asynchronous version of delete. "The request doesn't *missing* > actually until > * the asynchronous callback is called." > */ > public void delete(final String path, int version, VoidCallback cb, > Object ctx) .. > Also some information in the javadoc about how to instantiate the callback > objects / context would be useful . -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira