[ https://issues.apache.org/jira/browse/ZOOKEEPER-731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097610#comment-13097610 ]
jirapos...@reviews.apache.org commented on ZOOKEEPER-731: --------------------------------------------------------- bq. On 2011-09-05 20:04:12, Patrick Hunt wrote: bq. > src/java/main/org/apache/zookeeper/ZooKeeper.java, lines 90-94 bq. > <https://reviews.apache.org/r/1715/diff/1/?file=37951#file37951line90> bq. > bq. > I suspect LOG is initialized in the static to make initialization explicit - given logEnv uses LOG as an argument. We'll lose this with this change, i.e. someone might re-refactor the code and lose the implicit ordering. At the very least it would be a good idea to document. Pat, I checked this into head already. Would you prefer I roll back this part of the change or just add a comment? - Camille ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1715/#review1753 ----------------------------------------------------------- On 2011-09-05 15:55:47, Thomas Koch wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/1715/ bq. ----------------------------------------------------------- bq. bq. (Updated 2011-09-05 15:55:47) bq. bq. bq. Review request for zookeeper. bq. bq. bq. Summary bq. ------- bq. bq. . bq. bq. bq. This addresses bug ZOOKEEPER-731. bq. https://issues.apache.org/jira/browse/ZOOKEEPER-731 bq. bq. bq. Diffs bq. ----- bq. bq. src/java/main/org/apache/zookeeper/ZooKeeper.java 00bac9f bq. bq. Diff: https://reviews.apache.org/r/1715/diff bq. bq. bq. Testing bq. ------- bq. bq. bq. Thanks, bq. bq. Thomas bq. bq. > Zookeeper#delete , #create - async versions miss a verb in the javadoc > ------------------------------------------------------------------------ > > Key: ZOOKEEPER-731 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-731 > Project: ZooKeeper > Issue Type: Bug > Components: documentation > Affects Versions: 3.3.0 > Reporter: Kay Kay > Assignee: Thomas Koch > Priority: Minor > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-731.patch > > > /** > * The Asynchronous version of delete. "The request doesn't *missing* > actually until > * the asynchronous callback is called." > */ > public void delete(final String path, int version, VoidCallback cb, > Object ctx) .. > Also some information in the javadoc about how to instantiate the callback > objects / context would be useful . -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira