[
https://issues.apache.org/jira/browse/ZOOKEEPER-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112595#comment-13112595
]
Benjamin Reed commented on ZOOKEEPER-1199:
------------------------------------------
-1 i don't think this is a valid issue. the op code evaluation is in time
critical code and we should be doing less type conversion rather than more. it
would be much better to write a utility class that converts from op code
integer to string.
> Make OpCode an enum
> -------------------
>
> Key: ZOOKEEPER-1199
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1199
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Attachments: ZOOKEEPER-1199.patch
>
>
> ZooDefs.OpCode is an interface with integer constants. Changing this to an
> enum provides safety. See "Item 30: Use enums instead of int constants" in
> Effective Java.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
