[
https://issues.apache.org/jira/browse/ZOOKEEPER-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112617#comment-13112617
]
Thomas Koch commented on ZOOKEEPER-1199:
----------------------------------------
Do you have some reference to back your concerns about a possible performance
impact of some Type conversions? I've been taught that nowadays you should not
micro-optimize your code because CPUs are fast enough. JVMs are also very
clever in doing optimizations for you.
Then you normally need to worry about disc and network performance, CPUs are
typically not the bottleneck. Isn't it right, that the time that a ZK requests
spends on the network is some orders of magnitude longer then the total CPU
time for one request?
Are there some numbers from Yahoo, which I could study to get a picture from
larger installations?
Then there's programmers time vs. machine time. A bigger machine is usually
cheaper then more developers. (This may become wrong when talking about Hadoop
scale, but ZK is only deployed to a handful of machines.)
It would be good, if we could have some automatic evaluation of the performance
impact as part of the Jenkins build...?
> Make OpCode an enum
> -------------------
>
> Key: ZOOKEEPER-1199
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1199
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Attachments: ZOOKEEPER-1199.patch
>
>
> ZooDefs.OpCode is an interface with integer constants. Changing this to an
> enum provides safety. See "Item 30: Use enums instead of int constants" in
> Effective Java.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
