[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thomas Koch updated ZOOKEEPER-1221:
-----------------------------------

    Attachment: ZOOKEEPER-1221.patch
    
> Provide accessors for Request.{hdr|txn}
> ---------------------------------------
>
>                 Key: ZOOKEEPER-1221
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1221
>             Project: ZooKeeper
>          Issue Type: Sub-task
>            Reporter: Thomas Koch
>            Assignee: Thomas Koch
>            Priority: Minor
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1221.patch, ZOOKEEPER-1221.patch
>
>
> I'm working on a larger patch that makes the Request class immutable. To see, 
> where the hdr and txn fields are modified, it helped to introduce accessor 
> methods. The JVM should happily inline the method calls so no performance 
> overhead should be expected.
> There's a minor, unrelated change included: ToBeAppliedRequestProcessor had a 
> reference to the toBeApplied list of the Leader. So it was hard to find all 
> places, where this list was actually modified. The patch gives instead the 
> leader instance to the toBeAppliedRequestProcessor and the processor then 
> accesses leader.toBeApplied.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to